Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UserFeedback #2486

Merged
merged 10 commits into from
Sep 22, 2022
Merged

Add UserFeedback #2486

merged 10 commits into from
Sep 22, 2022

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

Close: #500

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

src/js/envelope.ts Outdated Show resolved Hide resolved
@krystofwoldrich
Copy link
Member Author

Example user feedback

Screenshot 2022-09-21 at 14 41 52

@krystofwoldrich krystofwoldrich marked this pull request as ready for review September 21, 2022 15:04
@krystofwoldrich krystofwoldrich marked this pull request as draft September 21, 2022 15:05
@krystofwoldrich krystofwoldrich marked this pull request as ready for review September 22, 2022 12:29
@marandaneto
Copy link
Contributor

@krystofwoldrich awesome, looking forward for the tests.

@krystofwoldrich
Copy link
Member Author

src/js/user.ts Outdated Show resolved Hide resolved
@marandaneto
Copy link
Contributor

@krystofwoldrich awesome, looking forward for the tests.

They are here #2486 (files)

Or you mean something else?

I had it open and didn't refresh the page, all good =D

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @krystofwoldrich

@krystofwoldrich krystofwoldrich enabled auto-merge (squash) September 22, 2022 13:56
@krystofwoldrich
Copy link
Member Author

Well done @krystofwoldrich

Thank you!

@krystofwoldrich krystofwoldrich merged commit 5d170b6 into main Sep 22, 2022
@krystofwoldrich krystofwoldrich deleted the krystofwoldrich/addUserFeedback branch September 22, 2022 13:57
@krystofwoldrich krystofwoldrich changed the title Add UserFeedback draft Add UserFeedback Sep 22, 2022
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Add UserFeedback ([#2486](https://github.com/getsentry/sentry-react-native/pull/2486))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 47b0837

@itsramiel
Copy link

are there docs on how to use?

@KrisLau
Copy link

KrisLau commented Sep 29, 2022

Clicking see an example from the dashboard and sending the user feedback from there doesn't seem to work at all.
image

@SamMakesThings
Copy link

Agreed with @itsramiel - would love a guide on implementing

@krystofwoldrich
Copy link
Member Author

krystofwoldrich commented Oct 3, 2022

There is a small snippet in the docs or you can take a look into the sample app, UserFeedbackModal component.

@itsramiel @KrisLau @StartupSam I hope these links help.

@KrisLau Thanks for the info, the button on the page doesn't seem to add User Feedback. You can try it out in the sample app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE REQUEST: User Feedback
6 participants