🏷️ Add typings for app hang functionality #2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandergo90
requested review from
marandaneto and
bruno-garcia
as code owners
|
Thanks @sandergo90 |
|
Hi! We have enabled it already in our application with a ts-expect-error comment ;) I've debugged in the iOS code, and it activated the app hanging perfectly. |
marandaneto
reviewed
Sep 22, 2022
|
@sandergo90 thank you, please add a changelog entry and ready to go :) |
|
Done and done 👌 |
marandaneto
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
The sentry iOS sdk contains functionality to log a message to sentry when the app hangs.
This is not available in the types now. This pull requests adds the typings.
📝 Checklist
🔮 Next steps