maxTransactionDuration should be ms when passing to startIdleTransaction

[marandaneto]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

📜 Description

sentry-react-native/src/js/tracing/reactnativetracing.ts

Lines 42 to 49 in b6fe289

	/**
	* The maximum duration of a transaction before it will be marked as "deadline_exceeded".
	* If you never want to mark a transaction set it to 0.
	* Time is in seconds.
	*
	* Default: 600
	*/
	maxTransactionDuration: number;

maxTransactionDuration is documented as in seconds.

https://github.com/getsentry/sentry-javascript/blob/fbd4ef07dd4248a1a9f8a80e0c220628a663f91c/packages/tracing/src/idletransaction.ts#L79-L87
defines both values in ms

When passing the values to the idle transaction, we need to convert the one in seconds to milliseconds

sentry-react-native/src/js/tracing/reactnativetracing.ts

Lines 363 to 364 in b6fe289

	idleTimeout,
	maxTransactionDuration,

💡 Motivation and Context

#2468
#2467

💚 How did you test it?

📝 Checklist

• I reviewed submitted code
• I added tests to verify changes
• All tests passing
• No breaking changes

🔮 Next steps

[krystofwoldrich]

I've tested this with our sample app. It works and fixes both of the mentioned issues.

[marandaneto]

@krystofwoldrich would you like to add the changelog entry, approve, merge and release it? :)

[krystofwoldrich]

Looks good. As we talked about how to improve the options I've wrote it down here #2471