Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update CLI to v2.7.0 #2457

Merged
merged 7 commits into from
Oct 20, 2022
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 6, 2022

Bumps scripts/update-cli.sh from 1.74.4 to 2.7.0.

Auto-generated by a dependency updater.

Changelog

2.7.0

Various fixes & improvements

  • fix: paths argument for debug-files find should take a value (#1346) by kamilogorek
  • chore: reuse danger workflow (#1332) by vaind

2.6.0

Various fixes & improvements

  • fix: Update symbolic to fix spurious EOF errors (#1339) by Swatinem
  • fix: Break out of the loop when we reach cursor limit for list_release_files (#1337) by kamilogorek
  • ref: Provide better user messages for properties file configs (#1336) by kamilogorek
  • feat(sourcemaps): Add no-dedupe flag for skipping deduplication (#1334) by kamilogorek
  • misc: Add note about MSVC requirement (#1333) by kamilogorek
  • ref: Use better artifacts url resolution for sourcemaps explain (#1329) by kamilogorek
  • feat: Add top-level events command with list subcommand (#1307) by dcariotti

2.5.2

Various fixes & improvements

  • fix: Use direct plist env vars fallback when called within xcode itself (#1311) by kamilogorek

2.5.1

Various fixes & improvements

  • fix: Fallback to xcodebuild vars for faulty Info.plist files (#1310) by kamilogorek
  • ref: Log warning when debug source excedes item size limit (#1305) by kamilogorek

2.5.0

Various fixes & improvements

  • feat: Allow for selecting frame in sourcemaps explain (#1293) by kamilogorek
  • misc: 1.74.5 changelog (#1291) by kamilogorek
  • chore: add missing changelog entry for 1.74.4 (#1289) by vaind

2.4.1

Various fixes & improvements

  • ref: Print better error when processing appcenter paths (#1287) by kamilogorek
  • fix: Make sure release exists before querying for artifacts (#1284) by kamilogorek

2.4.0

Various fixes & improvements

  • ci: Disable rustup self-update (#1278) by kamilogorek
  • feat: Add decompress flag to sourcemaps and files upload (#1277) by kamilogorek
  • feat: Use checksum to dedupe uploaded release artifacts (#1275) by kamilogorek

2.3.1

Various fixes & improvements

  • ref: Dont print install progressbar for nonTTY and CI=1 (#1270) by kamilogorek
  • fix: move dist option to SentryCliUploadSourceMapsOptions (#1269) by ikenfin

2.3.0

Various fixes & improvements

  • fix: Allow for using --auth-token with login command (#1266) by kamilogorek
  • deps: Update all Rust dependencies (#1265) by kamilogorek
  • fix: Increase TempFile robustness on Windows (#1256) (#1263) by kamilogorek
  • ref: Remove confusing ending dots from command logs (#1261) by kamilogorek
  • fix: Correct typo in sourcemaps explain output (#1258) by huwq1987
  • fix: Use first frame that has context-line in explain (#1255) by kamilogorek
  • feat: Add send-envelope command (#1254) by kamilogorek

2.2.0

Various fixes & improvements

  • feat: Compute and upload il2cpp line mappings (#1248) by loewenheim
  • ref: Skip protected zip files when uploading debug files (#1245) by kamilogorek

2.1.0

Source Maps Upload Check "y-tho" (ongoing)

Problem statement:

Uploading source maps is a common source of frustration. Source maps are also one of the great value adds to our in product experience. We want to automate supporting customers with frequent issues.

https://docs.sentry.io/platforms/javascript/sourcemaps/troubleshooting_js/

*Outcome: *

Developers will be provided with a tool to help them discover any issues they may have when uploading source maps

Sentry support will have a tool and docs to suggest to customers to hopefully first discover issues, and second at least know what their problem is NOT.

Key measurements:

  • qualitative: Is this useful for customers and support
  • quantitative: Can we try to influence the number of Zendesk tickets
  • quantitative: Can we influence the resolution time of source maps related Zendesk tickets

Can we find a way to track in zendesk the number of times the sentry-cli “y-tho“ functionality was useful

Additional

This is something users would run locally so I do not think we can track usage exactly what was not covered in y-tho

  • Verify your source maps are built correctly
  • Verify your source maps work locally
  • Verify your source files are not too large
    • this is a fuzzy requirement today in sentry
  • Verify artifacts are not gzipped
  • Verify workers are sharing the same volume as web (if running self-hosted Sentry via Docker)
  • Should spit out an easily readable and easily copy and paste - to put into ZenDesk or elsewhere for support colleagues

Possible second milestone:

https://github.com/getsentry/rust-sourcemap/tree/master/cli

  • In sentry error incorrect source map location
  • this helps when producing sourcemaps locally then line and column
  • this verify that it resolves locally
    • if yes then it is a problem in between on sentry server side or upload
    • 1st Verifies what you upload to sentry is exactly what you upload to sentry
    • 2nd step from “y-tho” ensure previous steps are not for waste
  • What is being automated?
    • on release page you have your files (release artificats)
      • download
      • manually check the line number matches the error
      • if correct then data is correct
      • then you know an error with cli and not with the source maps that were uploaded

By: kamilogorek (#1235)

Various fixes & improvements

  • ref: Change comment format for find_matching_artifact (#1243) by kamilogorek
  • ref: Log correct AppCenter error message (#1243) by kamilogorek
  • fix: Respect no-zips option for debug files upload (#1239) by saf-e
  • chore: fix recommended VS Code extension name (#1240) by vaind
  • ref: Rename VERSION to SENTRY_CLI_VERSION in install readme (#1227) by kamilogorek
  • feat: Add organizations list command (#1213) by kamilogorek
  • docs(cli): Sync get-cli readme with our docs; add version specifier (#1225) by kamilogorek
  • test: Add integration tests for projects command (#1212) by kamilogorek
  • fix: replace git.io links with redirect targets (#1209) by asottile-sentry

2.0.4

Various fixes & improvements

  • ref: Prevent vercel/nft and similar tools from including binary file in their bundles (#1207) by kamilogorek
  • ref: Use node-fetchv2 for the simplicity sake (#1206) by kamilogorek

2.0.3

Various fixes & improvements

  • ref: Make --header a global flag so its position independent (#1194)
  • ref: Restore monitors as hidden command w. integration tests (#1196)
  • ref: Restore bash-hook as hidden command w. integration tests (#1197)

2.0.2

Various fixes & improvements

  • fix: Remove fetch.FetchError usage in favor of catch-all clause (#1193) by kamilogorek
  • ref: Restore and hide legacy aliases from 1.x for backward compatibility (#1192) by kamilogorek

2.0.1

Various fixes & improvements

  • fix: Allow hyphenated release names with any flags position (#1187) by kamilogorek

2.0.0

This is the first, long-overdue major release in over 5 years of sentry-cli's life.
Some APIs were removed, some reworked, some newly added.

Most of introduced API changes are backward compatible through hidden aliases, so there is no immediate need for users developing 3rd party tools to make all the changes immediatelly.
We do however encourage everyone to do it sooner or later, as deprecated items will be removed in the next major releases.

Breaking changes are denotated with (breaking) tag, and appropriate required changes are provided for each entry.

New APIs

  • feat: Add debug-files command, which is a joined functionality of difutil and upload-dif commands.
  • feat: Add deploys command, which was extracted from releases deploys subcommand.
  • feat: Add files command, which was extracted from releases files subcommand.
  • feat: Add sourcemaps upload command, which was extracted from releases files upload-sourcemaps subcommand.
  • feat: Add sourcemaps resolve command.
  • feat: Allow for specifying global --header argument, which supports multiple occurences, to configure outgoing requests
  • feat: Implement global --quiet/--silent flags to allow silencing stdout output (This flag is currently implemented only for selected subcommands)

Removed APIs

  • ref: Remove react-native codepush subcommand (use react-native appcenter instead) (breaking)
  • ref: Remove react-native-gradle and react-native-xcode commands (use react-native gradle and react-native xcode instead) (breaking)
  • ref: Remove crash_reporting related code and with_crash_reporting crate feature (no required changes) (breaking)
  • ref: Remove SENTRY_NO_PROGRESS_BAR env var in favor of SENTRYCLI_NO_PROGRESS_BAR (rename env variable) (breaking)
  • ref: Hide difutil id subcommand (use debug-files check instead)
  • ref: Hide upload-dsym command (use debug-files upload instead)
  • ref: Make releases upload-sourcemaps --rewrite a default behavior now
  • ref: Remove upload-dsym command (use debug-files upload instead) (breaking) restored in 2.0.2 as hidden alias
  • ref: Remove difutil id subcommand (use debug-files check instead) (breaking) restored in 2.0.2 as hidden alias
  • ref: Remove monitors command (support for this feature has been dropped) (breaking) - restored in 2.0.3 as hidden command
  • ref: Remove bash-hook command (use 1.x if you still need the functionality) (breaking) - restored in 2.0.3 as hidden command

Breaking Changes

  • ref: Update minimal required node version to v12 (update node version) (breaking)
  • ref: Rename --header argument of releases files upload command to --file-header (rename flag) (breaking)
  • ref: Rename CUSTOM_HEADER to SENTRY_HEADER and defaults.custom_header to http.header (rename env variable or update config file) (breaking)
  • ref: Make ignore-empty for releases set-commits a default behavior and hide --ignore-empty flag (remove --ignore-empty usage) (breaking)

Various fixes & improvements

  • feat: Implement --quiet flag for releases upload-sourcemaps command
  • feat: Implement --quiet flag for difutil check command
  • ref: Make --auth-token a global argument
  • ref: Make all ProgressBar instances and logs always write to stderr
  • ref: Migrate error handling from failure to anyhow crate

1.74.5

Various fixes & improvements

  • deps: Add resolution to bump ansi-regex to version ^3.0.1 (#1281)
  • ref: Increase TempFile robustness on Windows (#1256)

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Sep 6, 2022
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cli.sh branch 4 times, most recently from 16ce3f0 to 1819cbc Compare September 7, 2022 11:52
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cli.sh branch 8 times, most recently from f48fb71 to 4927916 Compare September 19, 2022 13:29
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cli.sh branch 13 times, most recently from 110c0eb to 3ab1069 Compare September 26, 2022 08:26
@github-actions github-actions bot changed the title chore(deps): update CLI to v2.5.2 chore(deps): update CLI to v2.6.0 Sep 27, 2022
@krystofwoldrich krystofwoldrich force-pushed the deps/scripts/update-cli.sh branch from 403b06e to be8afb6 Compare October 16, 2022 18:37
@krystofwoldrich krystofwoldrich changed the base branch from main to 5.0.0 October 16, 2022 18:37
@github-actions
Copy link
Contributor Author

github-actions bot commented Oct 16, 2022

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 334.49 ms 340.78 ms 6.29 ms
Size 25.82 MiB 27.83 MiB 2.01 MiB

Baseline results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
70013c7 344.17 ms 358.76 ms 14.59 ms
b5eddfa 346.86 ms 367.67 ms 20.82 ms
b9ac2e8 314.22 ms 321.52 ms 7.30 ms
17717b8 315.32 ms 329.42 ms 14.10 ms
3dd1a5b 337.06 ms 344.50 ms 7.44 ms
2a133c2 336.00 ms 341.78 ms 5.78 ms
cc863df 331.40 ms 350.44 ms 19.04 ms
b4d768b 316.47 ms 334.06 ms 17.59 ms

App size

Revision Plain With Sentry Diff
70013c7 25.82 MiB 27.83 MiB 2.01 MiB
b5eddfa 25.82 MiB 27.86 MiB 2.04 MiB
b9ac2e8 25.82 MiB 27.83 MiB 2.01 MiB
17717b8 25.82 MiB 27.86 MiB 2.04 MiB
3dd1a5b 25.82 MiB 27.83 MiB 2.01 MiB
2a133c2 25.82 MiB 27.86 MiB 2.04 MiB
cc863df 25.82 MiB 27.83 MiB 2.01 MiB
b4d768b 25.82 MiB 27.86 MiB 2.04 MiB

Previous results on branch: deps/scripts/update-cli.sh

Startup times

Revision Plain With Sentry Diff
1fae0f0 335.92 ms 339.98 ms 4.06 ms

App size

Revision Plain With Sentry Diff
1fae0f0 25.82 MiB 27.83 MiB 2.01 MiB

@github-actions
Copy link
Contributor Author

github-actions bot commented Oct 16, 2022

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.35 ms 1232.82 ms 4.47 ms
Size 1.08 MiB 1.44 MiB 371.41 KiB

Baseline results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
b5eddfa 1252.54 ms 1254.76 ms 2.22 ms
70013c7 1237.84 ms 1258.46 ms 20.62 ms
3dd1a5b 1272.44 ms 1292.88 ms 20.44 ms
cc863df 1256.06 ms 1263.54 ms 7.48 ms
b4d768b 1236.63 ms 1257.16 ms 20.53 ms
2a133c2 1232.78 ms 1238.56 ms 5.78 ms
17717b8 1264.14 ms 1269.94 ms 5.80 ms

App size

Revision Plain With Sentry Diff
b5eddfa 1.08 MiB 1.44 MiB 367.28 KiB
70013c7 1.08 MiB 1.44 MiB 371.41 KiB
3dd1a5b 1.08 MiB 1.44 MiB 371.41 KiB
cc863df 1.08 MiB 1.44 MiB 371.41 KiB
b4d768b 1.08 MiB 1.44 MiB 370.50 KiB
2a133c2 1.08 MiB 1.44 MiB 370.49 KiB
17717b8 1.08 MiB 1.44 MiB 363.17 KiB

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cli.sh branch 2 times, most recently from eaa529c to 4b0c498 Compare October 17, 2022 03:59
@krystofwoldrich krystofwoldrich force-pushed the deps/scripts/update-cli.sh branch from 4b0c498 to 393c711 Compare October 17, 2022 07:37
@krystofwoldrich
Copy link
Member

@marandaneto Only the Xcode debug upload used deprecated commands. I've updated that here getsentry/sentry-wizard#199 and also added the --include-sources option.

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cli.sh branch from 393c711 to dfffb03 Compare October 17, 2022 09:12
@krystofwoldrich krystofwoldrich force-pushed the deps/scripts/update-cli.sh branch from dfffb03 to c09b501 Compare October 17, 2022 10:33
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cli.sh branch from c09b501 to a7febfb Compare October 18, 2022 03:52
@krystofwoldrich krystofwoldrich force-pushed the deps/scripts/update-cli.sh branch from a7febfb to 152c9cc Compare October 19, 2022 09:52
@krystofwoldrich
Copy link
Member

The SENTRY_INCLUDE_NATIVE_SOURCES can be added simply in Xcode UI or just in a terminal.
This should be convenient enough for our users.

Screenshot 2022-10-19 at 11 46 25

@krystofwoldrich krystofwoldrich requested review from marandaneto and removed request for bruno-garcia and krystofwoldrich October 19, 2022 09:55
@marandaneto
Copy link
Contributor

Let's figure out this first #2556
Because if acceptable, we could actually remove the cli from dependencies.

One suggestion is compiling the final app with or without the cli as a dependency and see the overhead of the package.
That could be possible by using our metrics #2457 (comment)
Or manually.

@krystofwoldrich krystofwoldrich merged commit 7c2d318 into 5.0.0 Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants