-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transaction source for dynamic sampling #2454
Conversation
@krystofwoldrich |
In browser land we almost exclusively use route/url. I originally thought that view was the most fitting here judging by the name. But if we use component in android I'd use that just to be consistent. If we want we could update the docs to be a little more specific on what the differences are. |
Seems android should also be |
@krystofwoldrich Thank you for doing that, I liked the refactoring, it makes it easier to read. |
@krystofwoldrich after merging and releasing this, let's update the docs. |
The only missing part now is test with backend. That can happen when the React Native will be allowed for Dynamic Sampling. |
Test on production, source is send correctly. Dynamic sampling on server is also working. From 10 transaction only 2 were processed when sampling set to 20%. |
📢 Type of change
📜 Description
I've added default
view
source for all the integration, which can be overwritten by the user.I've picked
view
as its description fitted the most to what it actually is. ExampleHome
,Menu
,ProfilePage
etc.https://develop.sentry.dev/sdk/event-payloads/transaction/#transaction-annotations
💡 Motivation and Context
At the moment the source is always
custom
, because we first create empty transaction and then update it with the correct route data, which causes the source to be set ascustom
.getsentry/team-mobile#46
💚 How did you test it?
🚨 To be done when sentry backend will allow dynamic sampling for React Native.
📝 Checklist
🔮 Next steps