Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactNativeTracing wrongly marks transactions as deadline_exceeded when it reaches the idleTimeout #2427

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Aug 18, 2022

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

ReactNativeTracing wrongly marks transactions as deadline_exceeded when it reaches the idleTimeout

💡 Motivation and Context

Bug was introduced when migrating the JS SDK to v7
Fix #2426

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto merged commit 22ddfe3 into main Aug 18, 2022
@marandaneto marandaneto deleted the fix/max-timeout branch August 18, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High Failure Rate while using new SDK automatic instrumentation
2 participants