-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should not ignore options.transport
function provided in Sentry.init(...)
#2398
Conversation
@zivl please add the changelog entry. |
options.transport
function provided in Sentry.init(...)
@marandaneto change requests are done. please review again |
Awesome.
When fixing this, we are ready to LGTM. |
@marandaneto I can't get out of it without really put a |
We can eslint-ignore it, no problem. |
📢 Type of change
📜 Description
I've updated the ReactNativeClient constructor to first check if
options.transport
is provided and if so - then it takes it and calls tosuper(options)
. Ifoptions.transport
not provided then keep the previous logic and conduct react-native transport layer and then calls tosuper(options)
.💡 Motivation and Context
this resolves issue #2397
💚 How did you test it?
I've added a test which gets the given custom transport layer and then runs and validates the customized
send
andflush
functions.📝 Checklist
🔮 Next steps