Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Calculate the absolute number of Android versionCode #2313

Merged
merged 6 commits into from
Jun 23, 2022
Merged

Fix Calculate the absolute number of Android versionCode #2313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
794f6d4
Fix: Calculate the absolute number of versionCode
marandaneto Jun 23, 2022
68abba2
changelog
marandaneto Jun 23, 2022
5cd8c1a
pr id
marandaneto Jun 23, 2022
2523be9
Update CHANGELOG.md
marandaneto Jun 23, 2022
288b0d5
Merge branch 'main' into fix/negative-version-code
marandaneto Jun 23, 2022
3bf66ed
Merge branch 'main' into fix/negative-version-code
marandaneto Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## 4.0.1

- Fix Calculate the absolute number of Android versionCode ([#2313](https://github.com/getsentry/sentry-react-native/pull/2313))
- Filter out app start with more than 60s ([#2303](https://github.com/getsentry/sentry-react-native/pull/2303))

## 4.0.0
Expand Down
3 changes: 2 additions & 1 deletion sentry.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,12 @@ gradle.projectsEvaluated {
variant = currentVariant[0]
releaseName = currentVariant[1]
versionCode = currentVariant[2]
def absVersionCode = Math.abs(versionCode)

// The Sentry server distinguishes source maps by release (`--release` in the command
// below) and distribution identifier (`--dist` below). Give the task a unique name
// based on where we're uploading to.
def nameCliTask = "${bundleTask.name}_SentryUpload_${releaseName}_${versionCode}"
def nameCliTask = "${bundleTask.name}_SentryUpload_${releaseName}_${absVersionCode}"

// If several outputs have the same releaseName and versionCode, we'd do the exact same
// upload for each of them. No need to repeat.
Expand Down