-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MacOS support #2240
MacOS support #2240
Conversation
The Flutter SDK does the same thing, https://github.com/getsentry/sentry-dart/blob/main/flutter/ios/Classes/SentryFlutterPluginApple.swift |
Sure, thanks for the review, I'm not very experienced in the native space and also no idea about other sentry features, but the snippets in the FlutterSDK do make a lot of sense :) |
Happy to guide :) thanks for the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping us out on this @ospfranco.
@ospfranco Please add an entry to the
We have E2E tests running on iOS, so it should be fine as it is. |
Co-authored-by: Manoel Aranda Neto <[email protected]>
Co-authored-by: Manoel Aranda Neto <[email protected]>
@marandaneto done, someone with access needs to approve the workflow to run the tests |
It looks good to me. |
Tests are not happy, but doesn't look like it is due to my changes. |
📢 Type of change
📜 Description
By conditionally compiling some of the more advanced functionality the SDK now compiles on react-native-macos applications. Don't know how the commented functionality works, XCode was simply throwing errors on the methods, which I guess are not exposed/defined based on platform checks too.
💡 Motivation and Context
I need react-native-macos support for my applications. The commented functionality (performance tracking) is not vital for my use case, for now getting the errors is better than nothing.
💚 How did you test it?
I built my own app with support and the events are being received on Sentry. Not sure how to add tests for the macOS target though, since I didn't change any functionality not sure if this is necessary.
📝 Checklist
🔮 Next steps
Please review, let me know if you need me to add tests (and if so how/which). If everything is working a prompt release would be much appreciatted