fix: Discard prior transactions on react navigation dispatch #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
approved these changes
Feb 11, 2022
There was a problem hiding this comment.
The e2e for iOS broken is expected due to #2052
But Android should be green but seems to be flaky due to:
Error: The template is not valid. .github/workflows/e2e.yml (Line: 34, Col: 16): hashFiles('**/yarn.lock') couldn't finish within 120 seconds.
|
|
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
When multiple navigation actions are dispatched before the
routeChangeTimeoutMs, and the state does not change occur for a prior action, the transaction is not cancelled and sent with the blank "Route Change" transaction context. This change makes sure any navigation transaction that had a successful navigation state change is removed from the instrumentation (it'll still be present on the scope until finished) and any new navigation action dispatch will cancel any prior waiting transactions to ensure they won't be sent when they don't have a successful state change.💡 Motivation and Context
Fixes #2051
💚 How did you test it?
Added a jest test where multiple navigation actions were dispatched in a row
📝 Checklist
🔮 Next steps
As we did not recieve a reproduction, need to ask customer to see if bug is fixed.