feat: Allow disabling native SDK initialization but still use it

[jennmueng]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

📜 Description

Allows the user to disable the initialization of the Native SDK in the case that they already have one initialized themselves. We do this by adding the shouldInitializeNativeSdk key to ReactNativeOptions. This is not breaking as it will default to true.

💡 Motivation and Context

User has an app that is extensively native iOS and the React Native section is only run way later: #1248

💚 How did you test it?

Wrote a new test in wrapper.ts.

📝 Checklist

• I reviewed submitted code
• I added tests to verify changes
• All tests passing
• No breaking changes

🔮 Next steps

Should add documentation on this option.

[github-actions]

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against dd56271

[marandaneto]

what are the edge cases of such flag?

eg 1. RN SDK captures an event, Native SDKs are not inited.
2. RN sets up X DSN but events go to Y DSN etc...

not against it, but we'll need to figure out such edge cases and write them down.

[jennmueng]

Yes I agree, should mention any possible side effects and edge cases, and also need to document this clearly. Thanks for the catch!

[pioneer32]

Being the author of the initial feature request, I'd like to add my 2 cents: Having the only source for DSN/environment etc would be a better option, so that I don't need to worry about that in the JS side, since it'd've been already fully initialised and configured on the native side.

[marandaneto]

@pioneer32 that would be the perfect solution, agree, but I'd say we'd go the other way around.
we'd sync the options from RN -> Native as we already do, which is let's say ~90+% of the use cases.
you could open an issue as a feature request and let's see if it gets upvoted, but I'd bet on the case described above.

[pioneer32]

@marandaneto Thank you for clarification! My guess is shouldInitializeNativeSdk sort of going to disable calling

sentry-react-native/ios/RNSentry.m

Line 67 in 97b16b7

[SentrySDK startWithOptionsObject:sentryOptions];

somehow (I might be wrong though). However, being keen to see what it'd look like, I commented out that line intentionally, and it seems to work as expected, almost :) FYI The problem I encountered was: all the tags/breadcrumbs/etc set to the native client are NOT copied into JS client before sending an error from JS.

[bruno-garcia]

LGTM

[bruno-garcia]

For reference, this came up in Flutter too already: getsentry/sentry-dart#255 (comment)