Streamline exception handling #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazAT
changed the title
|
If you just use native code as a transport layer then what's the advantage of using native code vs using raven-js to send message/data to sentry server? also does this change capture native errors/stacktrace (not JS errors, Java or Objective-C error) and report to sentry server? |
|
Hey, we recommend using the native code as a transport layer because you get a lot more useful information out of your crashes. Mostly information about the device. |
HazAT
changed the title
mitsuhiko
approved these changes
Jun 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This streamlines the exception handling and always uses raven-js to capture the exception, we just use the native client as a transport layer.
Fix Exception doesn't get sent to sentry while in dev mode? #110
This is required Add shouldSendEvent callback sentry-java#428