fix: assign default options before enableNative check #1007
Conversation
|
Note sure how CI breaks: This change is unrelated |
This actually breaks because the function returns a |
src/js/sdk.ts
Outdated
| @@ -71,10 +71,10 @@ export function init( | |||
| }, | |||
| }) | |||
| ); | |||
| options = assignDefaultOptions(options); | |||
There was a problem hiding this comment.
| options = assignDefaultOptions(options); | |
| options = { | |
| ...DEFAULT_OPTIONS, | |
| ...options | |
| } |
Instead of using a function call, I would do this and define the DEFAULT_OPTIONS as a constant object, this way typescript knows for sure that defaultIntegrations is defined.
There was a problem hiding this comment.
This file needs a massive refactor/clean now that I look at it, but I'll take care it later.
There was a problem hiding this comment.
good idea 👍
addressed in the most recent commit
There was a problem hiding this comment.
Oh the build is failing still, this would be fixed if you move the default options setting code before the if statement that sets the default integrations above it. Otherwise everything else looks good.
There was a problem hiding this comment.
gotchya, fixed that & the build is passing now
📢 Type of change
📜 Description
the changes i made in #993 result in
deviceContextnot initializing by default, since the defaultenableNative:trueisn't set until right after💡 Motivation and Context
#993 (comment)
💚 How did you test it?
existing tests
📝 Checklist
🔮 Next steps