Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues on iOS native integration #280

Closed
2 of 5 tasks
edo1493 opened this issue Oct 20, 2017 · 3 comments
Closed
2 of 5 tasks

Performance issues on iOS native integration #280

edo1493 opened this issue Oct 20, 2017 · 3 comments
Assignees

Comments

@edo1493
Copy link

edo1493 commented Oct 20, 2017

OS:

  • Windows
  • MacOS
  • Linux

Platform:

  • iOS
  • Android

Output of node -v && npm -v && npm ls --prod --depth=0

Config:

Sentry.config(Config.SENTRY_DSN, {deactivateStacktraceMerging: true}).install();


I have following issue:

If I use raven-js, I don't see any problem. Whenever I link sentry to start tracking native events, the performance of the app drops. I see frames being dropped for pretty much every action I dispatch (I use react-redux) and also nav transitions (react-navigation).

I have tried to deactivate the merging of the stacktrace, but I don't see much difference. I have tried both debug and release environments. I have no idea what could be conflicting here and I can understand this bug report is not really clear.

Steps to reproduce:

  • Two actions dispatched to refresh a scrollview or a simple navigation transition.

Actual result:

  • All the frames dropped and lag on the refresh animation.

Expected result:

  • 60 frames per second
@HazAT
Copy link
Member

HazAT commented Oct 23, 2017

Hey, are you running your app in DEV?
If so try running in in RELEASE, also if you have time can you maybe try this branch and see if it fixes your problem:
#282

It's just changes in RNSentry.m so you could copy the content and replace it locally and try if the performance issues are still there.

@HazAT HazAT self-assigned this Oct 23, 2017
HazAT added a commit that referenced this issue Oct 23, 2017
Handle unhandled promises
Fix stacktrace merging
Font send all breadcrumbs over bridge for new event
Fix ios device farm tests

Fixes #281
Fixes #280
@HazAT HazAT mentioned this issue Oct 24, 2017
HazAT added a commit that referenced this issue Oct 24, 2017
* fix(ios): Performance issues on main thread

* feat: Use shared javascript bridge helper from sentry-cocoa

Handle unhandled promises
Fix stacktrace merging
Font send all breadcrumbs over bridge for new event
Fix ios device farm tests

Fixes #281
Fixes #280

* fix: Move native client dependent calls into install

* fix: Set fatal on isFatal js error

* fix: iOS devicefarm tests

* meta: Update sentry-cocoa

* fix: Skip js frames

* meta: Bump sentry-cocoa to 3.9.0
@edo1493
Copy link
Author

edo1493 commented Oct 25, 2017

@HazAT I tried both Release and Dev. I will give the branch a go, thanks!

@HazAT
Copy link
Member

HazAT commented Oct 25, 2017

It is already released 0.30.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants