-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0.0-alpha.7] "Upload Debug Symbols to Sentry" build step uploads unresolved release metadata on iOS #2581
Comments
Thank you for the information, this might be related to the bump CLI from v1.74.4 to v2.7.0. I'll take a look at it. |
@AlexanderEggers Could you share your |
@krystofwoldrich this is my current script I am using for the build step: That used to work fine for any previous 5.0.0 alpha release - so it surprising that the latest one is breaking that integration. For example using alpha.6, my releases are properly uploaded including the right metadata. |
I've tried it with our sample app on the main branch and on the 5.0.0 and both behave the same. The release name is Could you send me an example of how your releases changed and does it behave correctly when you roll back to the previous version of the RN SDK? |
I have created a test release today using the latest alpha and my created release was called "0.1.0+$(CURRENT_PROJECT_VERSION)" (that is the actual name including the placeholder that is not replaced) on sentry.io - usually the name would be "0.1.0+1". As I mentioned, when rolling back to a previous sentry version, it fixes my issue. RN 0.70.4 was working with all the previous alpha versions, so it is highly likely related to changes in the CLI package. |
Thanks for the clarification I thought the name was replaced with a version. Could you check what version of the CLI you have in Did it happen only with one release or with all on the new alpha? |
@krystofwoldrich According to its package.json, version 2.7.0 was installed. That happened every time regardless how many times I was compiling the app. |
Could you send a small example app for a repro? I can't reproduce it and it seems like we have the same SDK, the same CLI version. |
Unfortunately that will take some time, I will try to take care of that by the end of next week. It is possible that this is very specific to my project, is there anything else I could try to provide which might help you? |
If I think of something I'll let you know. For now, I'll wait for the repro. |
I'm experiencing the same/similar issue after updating to version 4.7.1, cli @ 2.8.0 For us, the entire release and dist labels are coming through un-interpolated. For example, instead of coming in as Our Bundle React Native Code and Images script is
and our Upload Debug Symbols to Sentry script is:
|
@irothenbaum What command are you using to build your app or are you using Xcode GUI? |
We're using the Xcode GUI. Product -> Archive |
Hi! Update: Another strange thing is that Sentry tells me that the version with the correct package name was created earlier than the version with the generic package name. That's weird. |
The values should be read from the Xcode environment or Example: ...
export PRODUCT_BUNDLE_IDENTIFIER\=io.sentry.sample
... @Thanaen Could you create a minimal example app where we can reproduce the issue and upload a repo link or archive? |
Any updates here @AlexanderEggers ? |
I've opened PR in |
@krystofwoldrich Do you know when this fix will be available in a 4.x or 5.x release? |
FYI, fix was released in |
Confirmed this solved it for us. Thank you! |
OS:
Platform:
SDK:
@sentry/react-native
(>= 1.0.0)react-native-sentry
(<= 0.43.2)SDK version: 5.0.0-alpha.7
react-native
version: 0.70.4Are you using Expo?
Are you using sentry.io or on-premise?
I have following issue:
After updating to 5.0.0-alpha.7, I noticed that the xcode build step "Upload Debug Symbols" does not resolve the global
CURRENT_PROJECT_VERSION
properly anymore. Instead of resolving that into the actual current build number, it just takes the property name calling the sentry release0.1.0+$(CURRENT_PROJECT_VERSION)
. Other release details are broken as well including the package name.Steps to reproduce:
Actual result:
Broken release meta details on sentry.io.
Expected result:
Proper release meta details on sentry.io.
The text was updated successfully, but these errors were encountered: