Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v 2.8.0 release names not getting evaluated when uploading #1395

Closed
ajstokar opened this issue Nov 11, 2022 · 2 comments · Fixed by #1403
Closed

v 2.8.0 release names not getting evaluated when uploading #1395

ajstokar opened this issue Nov 11, 2022 · 2 comments · Fixed by #1403

Comments

@ajstokar
Copy link

ajstokar commented Nov 11, 2022

Environment

sentry-cli 2.8.0

Steps to Reproduce

Since upgrading to sentry-cli 2.8.0, the release names are not getting evaluated when we upload new releases. We have not added any customization to release names and this was previously working correctly on older versions.

Expected Result

Release names would be evaluated correctly when uploaded during a release build.

Actual Result

Release names include $(MARKETING_VERSION) and $(PRODUCT_BUNDLE_IDENTIFIER) as is, without getting evaluated. Our frontend app is using the following for Sentry.init.

Sentry.init({
                    dsn: Config.sentryDsn,
                    environment: Config.environment,
                    dist: DeviceInfo.getBuildNumber(),
                    release: `${DeviceInfo.getBundleId()}-${DeviceInfo.getVersion()}`,
                });

However, the release that is created by the automatic sourcemaps upload script (not custom) is not evaluating the environment variables and leaving them as is. See the below screenshot of the two releases, one is correct without sourcemaps, the other is incorrect but does include sourcemaps.

Screen Shot 2022-11-11 at 10 30 28 AM

@kamilogorek
Copy link
Contributor

Can you run your build with SENTRY_LOG_LEVEL=debug or --log-level=debug? It will give us more details on the upload and how plist file is read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants