Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry is delaying react-navigation transition #158

Closed
buesing opened this issue Jul 19, 2017 · 13 comments
Closed

Sentry is delaying react-navigation transition #158

buesing opened this issue Jul 19, 2017 · 13 comments
Assignees

Comments

@buesing
Copy link

buesing commented Jul 19, 2017

I was investigating react-navigation/react-navigation#608 and it looks like Sentry takes very long to parse an error during a transition. On a physical iPhone 6, it was delaying a transition by over 3 seconds. I found this by profiling with Instruments on macOS. Here's a screenshot of the stacktrace, where you can see that Sentry calls are blocking the transition for a long time. Removing Sentry from the app fixes the problem. I tried upgrading to the latest version, problem persists. Let me know if I can help with further details.

bildschirmfoto 2017-07-19 um 16 50 39

@HazAT
Copy link
Member

HazAT commented Jul 20, 2017

Hey, thx for reporting this.
For now you can just disable the stacktrace merging which should resolve the performance issue.
deactivateStacktraceMerging: true
https://docs.sentry.io/clients/react-native/config/
We are currently looking into improving the performance so this does not happen at all.

@jordanmkoncz
Copy link

I was having the same issue with react-navigation where I was experiencing a 1-2 second delay before transitioning to a new screen. After deactivating the stacktrace merging functionality in Sentry, the issue appears to be fixed.

@ChizuNoYama
Copy link

Where exactly is Sentry I don't seem to have it in my project

@huhuanming
Copy link

huhuanming commented Aug 8, 2017

I was having the same issue with react-navigation and sentry.

It's very smoothly in debug mode, bug so slow in release mode without any changes but sentry.

@huhuanming
Copy link

😳

@willlaserlike
Copy link

Same here. Hope a fix will be available soon. It slows down so much that almost make the app unusable.

@HazAT
Copy link
Member

HazAT commented Aug 24, 2017

Hey @huhuanming @willlaserlike,
Do you still have troubles when deactivating stacktrace merging?

@willlaserlike
Copy link

@HazAT Deactivating stacktrace seems to fix it. But stacktrace merging is kind of the key reason I choose Sentry so I wanna have it back plz...

@HazAT
Copy link
Member

HazAT commented Aug 24, 2017

@willlaserlike Are you running the latest version 0.20.0
We've released some performance improvements in the last few releases, I am still trying to reproduce this.
In the meantime, you could maybe upgrade to the latest version and try it again.

@huhuanming
Copy link

huhuanming commented Aug 27, 2017

thx.
I will update and test it later.

@plasticine
Copy link

plasticine commented Aug 27, 2017 via email

@HazAT
Copy link
Member

HazAT commented Aug 30, 2017

I've just released 0.22.0 which should fix the problem. Please try it out and tell me if it works.

@tommeier
Copy link

tommeier commented Sep 5, 2017

Hi @HazAT - Can confirm it has fixed the issue for us in deployed versions 🎉 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants