-
-
Notifications
You must be signed in to change notification settings - Fork 338
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(performance): Add Time to Full Display and manual API for TTID (#…
- Loading branch information
1 parent
9496de1
commit cc9666e
Showing
27 changed files
with
1,321 additions
and
44 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
139 changes: 139 additions & 0 deletions
139
android/src/main/java/io/sentry/react/RNSentryOnDrawReporterManager.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| package io.sentry.react; | ||
|
|
||
| import android.app.Activity; | ||
| import android.content.Context; | ||
| import android.view.View; | ||
|
|
||
| import com.facebook.react.bridge.Arguments; | ||
| import com.facebook.react.bridge.ReactApplicationContext; | ||
| import com.facebook.react.bridge.WritableMap; | ||
| import com.facebook.react.common.MapBuilder; | ||
| import com.facebook.react.uimanager.SimpleViewManager; | ||
| import com.facebook.react.uimanager.ThemedReactContext; | ||
| import com.facebook.react.uimanager.annotations.ReactProp; | ||
| import com.facebook.react.uimanager.events.RCTEventEmitter; | ||
|
|
||
| import org.jetbrains.annotations.NotNull; | ||
| import org.jetbrains.annotations.Nullable; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| import io.sentry.SentryDate; | ||
| import io.sentry.SentryDateProvider; | ||
| import io.sentry.android.core.AndroidLogger; | ||
| import io.sentry.android.core.BuildInfoProvider; | ||
| import io.sentry.android.core.SentryAndroidDateProvider; | ||
| import io.sentry.android.core.internal.util.FirstDrawDoneListener; | ||
|
|
||
| public class RNSentryOnDrawReporterManager extends SimpleViewManager<RNSentryOnDrawReporterManager.RNSentryOnDrawReporterView> { | ||
|
|
||
| public static final String REACT_CLASS = "RNSentryOnDrawReporter"; | ||
| private final @NotNull ReactApplicationContext mCallerContext; | ||
|
|
||
| public RNSentryOnDrawReporterManager(ReactApplicationContext reactContext) { | ||
| mCallerContext = reactContext; | ||
| } | ||
|
|
||
| @NotNull | ||
| @Override | ||
| public String getName() { | ||
| return REACT_CLASS; | ||
| } | ||
|
|
||
| @NotNull | ||
| @Override | ||
| protected RNSentryOnDrawReporterView createViewInstance(@NotNull ThemedReactContext themedReactContext) { | ||
| return new RNSentryOnDrawReporterView(mCallerContext, new BuildInfoProvider(new AndroidLogger())); | ||
| } | ||
|
|
||
| @ReactProp(name = "initialDisplay", defaultBoolean = false) | ||
| public void setInitialDisplay(RNSentryOnDrawReporterView view, boolean initialDisplay) { | ||
| view.setInitialDisplay(initialDisplay); | ||
| } | ||
|
|
||
| @ReactProp(name = "fullDisplay", defaultBoolean = false) | ||
| public void setFullDisplay(RNSentryOnDrawReporterView view, boolean fullDisplay) { | ||
| view.setFullDisplay(fullDisplay); | ||
| } | ||
|
|
||
| public Map getExportedCustomBubblingEventTypeConstants() { | ||
| return MapBuilder.builder().put( | ||
| "onDrawNextFrameView", | ||
| MapBuilder.of( | ||
| "phasedRegistrationNames", | ||
| MapBuilder.of("bubbled", "onDrawNextFrame") | ||
| ) | ||
| ).build(); | ||
| } | ||
|
|
||
| public static class RNSentryOnDrawReporterView extends View { | ||
|
|
||
| private final @Nullable ReactApplicationContext reactContext; | ||
| private final @NotNull SentryDateProvider dateProvider = new SentryAndroidDateProvider(); | ||
| private final @Nullable Runnable emitInitialDisplayEvent; | ||
| private final @Nullable Runnable emitFullDisplayEvent; | ||
| private final @Nullable BuildInfoProvider buildInfo; | ||
|
|
||
|
|
||
| public RNSentryOnDrawReporterView(@NotNull Context context) { | ||
| super(context); | ||
| reactContext = null; | ||
| buildInfo = null; | ||
| emitInitialDisplayEvent = null; | ||
| emitFullDisplayEvent = null; | ||
| } | ||
|
|
||
| public RNSentryOnDrawReporterView(@NotNull ReactApplicationContext context, @NotNull BuildInfoProvider buildInfoProvider) { | ||
| super(context); | ||
| reactContext = context; | ||
| buildInfo = buildInfoProvider; | ||
| emitInitialDisplayEvent = () -> emitDisplayEvent("initialDisplay"); | ||
| emitFullDisplayEvent = () -> emitDisplayEvent("fullDisplay"); | ||
| } | ||
|
|
||
| public void setFullDisplay(boolean fullDisplay) { | ||
| if (!fullDisplay) { | ||
| return; | ||
| } | ||
|
|
||
| registerForNextDraw(emitFullDisplayEvent); | ||
| } | ||
|
|
||
| public void setInitialDisplay(boolean initialDisplay) { | ||
| if (!initialDisplay) { | ||
| return; | ||
| } | ||
|
|
||
| registerForNextDraw(emitInitialDisplayEvent); | ||
| } | ||
|
|
||
| private void registerForNextDraw(@Nullable Runnable emitter) { | ||
| if (reactContext == null) { | ||
| return; | ||
| } | ||
|
|
||
| @Nullable Activity activity = reactContext.getCurrentActivity(); | ||
| if (activity == null || emitter == null || buildInfo == null) { | ||
| return; | ||
| } | ||
|
|
||
| FirstDrawDoneListener | ||
| .registerForNextDraw(activity, emitter, buildInfo); | ||
| } | ||
|
|
||
| private void emitDisplayEvent(String type) { | ||
| final SentryDate endDate = dateProvider.now(); | ||
|
|
||
| WritableMap event = Arguments.createMap(); | ||
| event.putString("type", type); | ||
| event.putDouble("newFrameTimestampInSeconds", endDate.nanoTimestamp() / 1e9); | ||
|
|
||
| if (reactContext == null) { | ||
| return; | ||
| } | ||
| reactContext | ||
| .getJSModule(RCTEventEmitter.class) | ||
| .receiveEvent(getId(), "onDrawNextFrameView", event); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| #import <UIKit/UIKit.h> | ||
| #import <React/RCTViewManager.h> | ||
| #import "RNSentryFramesTrackerListener.h" | ||
| #import <Sentry/SentryDependencyContainer.h> | ||
|
|
||
| @interface RNSentryOnDrawReporter : RCTViewManager | ||
|
|
||
| @end | ||
|
|
||
| @interface RNSentryOnDrawReporterView : UIView | ||
|
|
||
| @property (nonatomic, strong) RNSentryFramesTrackerListener* framesListener; | ||
| @property (nonatomic, copy) RCTBubblingEventBlock onDrawNextFrame; | ||
| @property (nonatomic) bool fullDisplay; | ||
| @property (nonatomic) bool initialDisplay; | ||
| @property (nonatomic, weak) RNSentryOnDrawReporter* delegate; | ||
|
|
||
| @end | ||
|
|
||
| @implementation RNSentryOnDrawReporter | ||
|
|
||
| RCT_EXPORT_MODULE(RNSentryOnDrawReporter) | ||
| RCT_EXPORT_VIEW_PROPERTY(onDrawNextFrame, RCTBubblingEventBlock) | ||
| RCT_EXPORT_VIEW_PROPERTY(initialDisplay, BOOL) | ||
| RCT_EXPORT_VIEW_PROPERTY(fullDisplay, BOOL) | ||
|
|
||
| - (UIView *)view | ||
| { | ||
| RNSentryOnDrawReporterView* view = [[RNSentryOnDrawReporterView alloc] init]; | ||
| return view; | ||
| } | ||
|
|
||
| @end | ||
|
|
||
| @implementation RNSentryOnDrawReporterView | ||
|
|
||
| - (instancetype)init { | ||
| self = [super init]; | ||
| if (self) { | ||
| RNSentryEmitNewFrameEvent emitNewFrameEvent = ^(NSNumber *newFrameTimestampInSeconds) { | ||
| if (self->_fullDisplay) { | ||
| self.onDrawNextFrame(@{ | ||
| @"newFrameTimestampInSeconds": newFrameTimestampInSeconds, | ||
| @"type": @"fullDisplay" | ||
| }); | ||
| return; | ||
| } | ||
|
|
||
| if (self->_initialDisplay) { | ||
| self.onDrawNextFrame(@{ | ||
| @"newFrameTimestampInSeconds": newFrameTimestampInSeconds, | ||
| @"type": @"initialDisplay" | ||
| }); | ||
| return; | ||
| } | ||
| }; | ||
| _framesListener = [[RNSentryFramesTrackerListener alloc] initWithSentryFramesTracker:[[SentryDependencyContainer sharedInstance] framesTracker] | ||
| andEventEmitter:emitNewFrameEvent]; | ||
| } | ||
| return self; | ||
| } | ||
|
|
||
| - (void)didSetProps:(NSArray<NSString *> *)changedProps | ||
| { | ||
| if (_fullDisplay || _initialDisplay) { | ||
| [_framesListener startListening]; | ||
| } | ||
| } | ||
|
|
||
| @end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.