Apply suggestions from code review

Co-authored-by: Antonis Lilis <[email protected]>
getsentry · Oct 14, 2024 · 9ed26d0 · 9ed26d0
1 parent a371274
commit 9ed26d0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/js/wrapper.ts b/src/js/wrapper.ts
@@ -409,7 +409,7 @@ export const NATIVE: SentryNativeWrapper = {
       const normalizedExtra = normalize(extra);
       stringifiedExtra = JSON.stringify(normalizedExtra);
     } catch (e) {
-      logger.error('Extra not passed to native SDK, because it contains non-stringifiable values', e);
+      logger.error('Extra for key ${key} not passed to native SDK, because it contains non-stringifiable values', e);
     }
 
     if (typeof stringifiedExtra === 'string') {
@@ -473,7 +473,7 @@ export const NATIVE: SentryNativeWrapper = {
     try {
       normalizedContext = convertToNormalizedObject(context);
     } catch (e) {
-      logger.error('Context not passed to native SDK, because it contains non-serializable values', e);
+      logger.error('Context for key ${key} not passed to native SDK, because it contains non-serializable values', e);
     }
 
     if (normalizedContext) {

diff --git a/test/wrapper.test.ts b/test/wrapper.test.ts
@@ -724,6 +724,7 @@ describe('Tests Native Wrapper', () => {
     test('handles null value by passing null to native method', () => {
       NATIVE.setContext('key', null);
       expect(RNSentry.setContext).toHaveBeenCalledWith('key', null);
+      expect(RNSentry.setContext).toHaveBeenCalledOnce();
     });
 
     test('handles undefined value by converting to object with "value" key', () => {
@@ -737,6 +738,7 @@ describe('Tests Native Wrapper', () => {
       circular.self = circular;
       NATIVE.setContext('key', circular);
       expect(RNSentry.setContext).toHaveBeenCalledWith('key', { self: '[Circular ~]' });
+      expect(RNSentry.setContext).toHaveBeenCalledOnce();
     });
   });
 });