Skip to content

Commit

Permalink
misc(sample): Rename com.sampleNewArchitecture to `io.sentry.reactn…
Browse files Browse the repository at this point in the history
…ative.sample` (#3762)
  • Loading branch information
krystofwoldrich authored Apr 19, 2024
1 parent b547994 commit 6476d2a
Show file tree
Hide file tree
Showing 34 changed files with 131 additions and 130 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/sample-application.yml
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,9 @@ jobs:
mkdir -p "DerivedData"
derivedData="$(cd "DerivedData" ; pwd -P)"
set -o pipefail && xcodebuild \
-workspace sampleNewArchitecture.xcworkspace \
-workspace sentryreactnativesample.xcworkspace \
-configuration "$CONFIG" \
-scheme sampleNewArchitecture \
-scheme sentryreactnativesample \
-destination 'platform=iOS Simulator,OS=${{ matrix.runtime }},name=${{ matrix.device }}' \
ONLY_ACTIVE_ARCH=yes \
-derivedDataPath "$derivedData" \
Expand Down
4 changes: 2 additions & 2 deletions samples/react-native/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,9 @@ android {
buildToolsVersion rootProject.ext.buildToolsVersion
compileSdkVersion rootProject.ext.compileSdkVersion

namespace "com.samplenewarchitecture"
namespace "io.sentry.reactnative.sample"
defaultConfig {
applicationId "com.samplenewarchitecture"
applicationId "io.sentry.reactnative.sample"
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
versionCode 1
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
package com.samplenewarchitecture;
import android.content.Context;
package io.sentry.reactnative.sample;

import com.facebook.react.bridge.Promise;
import com.facebook.react.bridge.ReactApplicationContext;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.samplenewarchitecture
package io.sentry.reactnative.sample

import android.os.Bundle
import com.facebook.react.ReactActivity
Expand All @@ -11,7 +11,7 @@ class MainActivity : ReactActivity() {
* Returns the name of the main component registered from JavaScript. This is used to schedule
* rendering of the component.
*/
override fun getMainComponentName(): String = "sampleNewArchitecture"
override fun getMainComponentName(): String = "sentry-react-native-sample"

/**
* Returns the instance of the [ReactActivityDelegate]. We use [DefaultReactActivityDelegate]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.samplenewarchitecture
package io.sentry.reactnative.sample

import android.app.Application
import com.facebook.react.PackageList
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.samplenewarchitecture
package io.sentry.reactnative.sample

import com.facebook.fbreact.specs.NativePlatformSampleModuleSpec
import com.facebook.react.bridge.ReactApplicationContext
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.samplenewarchitecture;
package io.sentry.reactnative.sample;
import com.facebook.react.ReactPackage;
import com.facebook.react.bridge.NativeModule;
import com.facebook.react.bridge.ReactApplicationContext;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.samplenewarchitecture
package io.sentry.reactnative.sample

import com.facebook.react.TurboReactPackage
import com.facebook.react.bridge.NativeModule
Expand Down
2 changes: 1 addition & 1 deletion samples/react-native/android/app/src/main/jni/OnLoad.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ JNIEXPORT jint JNICALL JNI_OnLoad(JavaVM *vm, void *) {

extern "C"
JNIEXPORT void JNICALL
Java_com_samplenewarchitecture_SamplePackage_crash(JNIEnv *env, jobject thiz) {
Java_io_sentry_reactnative_sample_SamplePackage_crash(JNIEnv *env, jobject thiz) {
char *ptr = 0;
*ptr += 1;
}
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<resources>
<string name="app_name">sampleNewArchitecture</string>
<string name="app_name">Sentry RN</string>
</resources>
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* <p>This source code is licensed under the MIT license found in the LICENSE file in the root
* directory of this source tree.
*/
package com.samplenewarchitecture;
package io.sentry.reactnative.sample;
import android.content.Context;
import com.facebook.react.ReactInstanceManager;
/**
Expand Down
2 changes: 1 addition & 1 deletion samples/react-native/android/settings.gradle
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
rootProject.name = 'sampleNewArchitecture'
rootProject.name = 'sentry-react-native-sample'
apply from: file("../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesSettingsGradle(settings)
include ':app'
includeBuild('../node_modules/@react-native/gradle-plugin')
4 changes: 2 additions & 2 deletions samples/react-native/app.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"name": "sampleNewArchitecture",
"displayName": "sampleNewArchitecture"
"name": "sentry-react-native-sample",
"displayName": "Sentry RN"
}
4 changes: 2 additions & 2 deletions samples/react-native/ios/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ if linkage != nil
use_frameworks! :linkage => linkage.to_sym
end

target 'sampleNewArchitecture' do
target 'sentryreactnativesample' do
config = use_native_modules!

use_react_native!(
Expand All @@ -45,7 +45,7 @@ target 'sampleNewArchitecture' do
pod 'RNSentry', :path => '../../..'
end

target 'sampleNewArchitectureTests' do
target 'sentryreactnativesampleTests' do
inherit! :complete
# Pods for testing
end
Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "13B07F861A680F5B00A75B9A"
BuildableName = "sampleNewArchitecture.app"
BlueprintName = "sampleNewArchitecture"
ReferencedContainer = "container:sampleNewArchitecture.xcodeproj">
BuildableName = "sentryreactnativesample.app"
BlueprintName = "sentryreactnativesample"
ReferencedContainer = "container:sentryreactnativesample.xcodeproj">
</BuildableReference>
</BuildActionEntry>
</BuildActionEntries>
Expand All @@ -33,9 +33,9 @@
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "00E356ED1AD99517003FC87E"
BuildableName = "sampleNewArchitectureTests.xctest"
BlueprintName = "sampleNewArchitectureTests"
ReferencedContainer = "container:sampleNewArchitecture.xcodeproj">
BuildableName = "sentryreactnativesampleTests.xctest"
BlueprintName = "sentryreactnativesampleTests"
ReferencedContainer = "container:sentryreactnativesample.xcodeproj">
</BuildableReference>
</TestableReference>
</Testables>
Expand All @@ -55,9 +55,9 @@
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "13B07F861A680F5B00A75B9A"
BuildableName = "sampleNewArchitecture.app"
BlueprintName = "sampleNewArchitecture"
ReferencedContainer = "container:sampleNewArchitecture.xcodeproj">
BuildableName = "sentryreactnativesample.app"
BlueprintName = "sentryreactnativesample"
ReferencedContainer = "container:sentryreactnativesample.xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
</LaunchAction>
Expand All @@ -72,9 +72,9 @@
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "13B07F861A680F5B00A75B9A"
BuildableName = "sampleNewArchitecture.app"
BlueprintName = "sampleNewArchitecture"
ReferencedContainer = "container:sampleNewArchitecture.xcodeproj">
BuildableName = "sentryreactnativesample.app"
BlueprintName = "sentryreactnativesample"
ReferencedContainer = "container:sentryreactnativesample.xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
</ProfileAction>
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ @implementation AppDelegate

- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
self.moduleName = @"sampleNewArchitecture";
self.moduleName = @"sentry-react-native-sample";
// You can add your custom initial props in the dictionary below.
// They will be passed down to the ViewController used by React
self.initialProps = @{};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<key>CFBundleDevelopmentRegion</key>
<string>en</string>
<key>CFBundleDisplayName</key>
<string>sampleNewArchitecture</string>
<string>Sentry RN</string>
<key>CFBundleExecutable</key>
<string>$(EXECUTABLE_NAME)</string>
<key>CFBundleIdentifier</key>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@
<rect key="frame" x="0.0" y="0.0" width="375" height="667"/>
<autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
<subviews>
<label opaque="NO" clipsSubviews="YES" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="sampleNewArchitecture" textAlignment="center" lineBreakMode="middleTruncation" baselineAdjustment="alignBaselines" minimumFontSize="18" translatesAutoresizingMaskIntoConstraints="NO" id="GJd-Yh-RWb">
<label opaque="NO" clipsSubviews="YES" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="RN Sample" textAlignment="center" lineBreakMode="middleTruncation" baselineAdjustment="alignBaselines" minimumFontSize="18" translatesAutoresizingMaskIntoConstraints="NO" id="GJd-Yh-RWb">
<rect key="frame" x="0.0" y="202" width="375" height="43"/>
<fontDescription key="fontDescription" type="boldSystem" pointSize="36"/>
<nil key="highlightedColor"/>
</label>
<label opaque="NO" clipsSubviews="YES" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="Powered by React Native" textAlignment="center" lineBreakMode="tailTruncation" baselineAdjustment="alignBaselines" minimumFontSize="9" translatesAutoresizingMaskIntoConstraints="NO" id="MN2-I3-ftu">
<label opaque="NO" clipsSubviews="YES" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="Powered by Sentry" textAlignment="center" lineBreakMode="tailTruncation" baselineAdjustment="alignBaselines" minimumFontSize="9" translatesAutoresizingMaskIntoConstraints="NO" id="MN2-I3-ftu">
<rect key="frame" x="0.0" y="626" width="375" height="21"/>
<fontDescription key="fontDescription" type="system" pointSize="17"/>
<nil key="highlightedColor"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
#define TIMEOUT_SECONDS 600
#define TEXT_TO_LOOK_FOR @"Welcome to React"

@interface sampleNewArchitectureTests : XCTestCase
@interface sentryreactnativesampleTests : XCTestCase

@end

@implementation sampleNewArchitectureTests
@implementation sentryreactnativesampleTests

- (BOOL)findSubviewInView:(UIView *)view matching:(BOOL (^)(UIView *view))test
{
Expand Down
2 changes: 1 addition & 1 deletion samples/react-native/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "sentry-react-native-bare-sample",
"name": "sentry-react-native-sample",
"version": "0.0.1",
"private": true,
"scripts": {
Expand Down

0 comments on commit 6476d2a

Please sign in to comment.