Skip to content

Commit

Permalink
fix: module access
Browse files Browse the repository at this point in the history
  • Loading branch information
vaind committed Jun 11, 2024
1 parent d5c8e67 commit 3d76fae
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 4 deletions.
2 changes: 1 addition & 1 deletion RNSentry.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ is_new_arch_enabled = ENV["RCT_NEW_ARCH_ENABLED"] == "1"
is_using_hermes = (ENV['USE_HERMES'] == nil && is_hermes_default) || ENV['USE_HERMES'] == '1'
new_arch_enabled_flag = (is_new_arch_enabled ? folly_compiler_flags + " -DRCT_NEW_ARCH_ENABLED" : "")
sentry_profiling_supported_flag = (is_profiling_supported ? " -DSENTRY_PROFILING_SUPPORTED=1" : "")
other_cflags = "$(inherited) -fcxx-modules -fmodules" + new_arch_enabled_flag + sentry_profiling_supported_flag
other_cflags = "$(inherited)" + new_arch_enabled_flag + sentry_profiling_supported_flag

Pod::Spec.new do |s|
s.name = 'RNSentry'
Expand Down
5 changes: 2 additions & 3 deletions ios/RNSentry.mm
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

#import "RNSentryEvents.h"
#import "RNSentryDependencyContainer.h"
#import "RNSentryBreadcrumbConverter.h"
#import "RNSentrySessionReplay.h"

#if SENTRY_HAS_UIKIT
#import "RNSentryRNSScreen.h"
Expand Down Expand Up @@ -91,8 +91,7 @@ + (BOOL)requiresMainQueueSetup {

[SentrySDK startWithOptions:sentryOptions];

RNSentryBreadcrumbConverter* breadcrumbConverter = [[RNSentryBreadcrumbConverter alloc] init];
[PrivateSentrySDKOnly configureSessionReplayWith: breadcrumbConverter screenshotProvider: nil];
[RNSentrySessionReplay setup];

#if TARGET_OS_IPHONE || TARGET_OS_MACCATALYST
BOOL appIsActive = [[UIApplication sharedApplication] applicationState] == UIApplicationStateActive;
Expand Down
6 changes: 6 additions & 0 deletions ios/RNSentrySessionReplay.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@

@interface RNSentrySessionReplay : NSObject

+ (void)setup;

@end
13 changes: 13 additions & 0 deletions ios/RNSentrySessionReplay.m
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
#import "RNSentrySessionReplay.h"
#import "RNSentryBreadcrumbConverter.h"

@implementation RNSentrySessionReplay {}

+ (void)setup {
RNSentryBreadcrumbConverter *breadcrumbConverter =
[[RNSentryBreadcrumbConverter alloc] init];
[PrivateSentrySDKOnly configureSessionReplayWith:breadcrumbConverter

Check failure on line 9 in ios/RNSentrySessionReplay.m

View workflow job for this annotation

GitHub Actions / Build legacy ios production dynamic-frameworks

no known class method for selector 'configureSessionReplayWith:screenshotProvider:'

Check failure on line 9 in ios/RNSentrySessionReplay.m

View workflow job for this annotation

GitHub Actions / Build legacy macos production no-frameworks

no known class method for selector 'configureSessionReplayWith:screenshotProvider:'

Check failure on line 9 in ios/RNSentrySessionReplay.m

View workflow job for this annotation

GitHub Actions / Build new ios dev no-frameworks

no known class method for selector 'configureSessionReplayWith:screenshotProvider:'

Check failure on line 9 in ios/RNSentrySessionReplay.m

View workflow job for this annotation

GitHub Actions / Build legacy ios dev dynamic-frameworks

no known class method for selector 'configureSessionReplayWith:screenshotProvider:'

Check failure on line 9 in ios/RNSentrySessionReplay.m

View workflow job for this annotation

GitHub Actions / Build legacy ios production no-frameworks

no known class method for selector 'configureSessionReplayWith:screenshotProvider:'

Check failure on line 9 in ios/RNSentrySessionReplay.m

View workflow job for this annotation

GitHub Actions / Build legacy ios dev no-frameworks

no known class method for selector 'configureSessionReplayWith:screenshotProvider:'

Check failure on line 9 in ios/RNSentrySessionReplay.m

View workflow job for this annotation

GitHub Actions / Build new ios production no-frameworks

no known class method for selector 'configureSessionReplayWith:screenshotProvider:'

Check failure on line 9 in ios/RNSentrySessionReplay.m

View workflow job for this annotation

GitHub Actions / Build legacy macos dev no-frameworks

no known class method for selector 'configureSessionReplayWith:screenshotProvider:'
screenshotProvider:nil];
}

@end

0 comments on commit 3d76fae

Please sign in to comment.