feat: Add reason for in_app to frames #3672
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sentry enhances the in_app decision from the SDK, sometimes overriding it. In cases the decision to set in_app to True comes from the user themselves (by setting in_app_include), we don't want Sentry to override the decision. Currently there's no way for Sentry to know what led to the decision in the SDK. Changing that here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentry enhances the
in_appdecision from the SDK, sometimes overriding it.In case the decision to set
in_apptoTruecomes from the user themselves (by settingin_app_include), we don't want Sentry to override it.Currently there's no way for Sentry to know what led to the decision in the SDK. Changing that here.
Draft: To be clarified whether
in_app_include_usedshould contain the actual prefix from the user'sin_app_includeor a general category likein_project_root,in_app_includeoutlining the general reason for marking it as in app.Closes #3671