feat: Add opportunistic Brotli compression #3612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brotli level 4 and 5 offer comparable or better compression to GZip level 9 (which is our default) with better performance. This patch adds opportunistic Brotli compression at level 4 (to be conservative) when it detects the `brotli` module is available. It also provides some escape hatches through `transport_compression_level` and `transport_compression_algo` experiment configs to fine tune the behavior. In the future, we may want to bump the default level from 4 to 5 for better compression.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #3612 +/- ##
==========================================
- Coverage 84.27% 84.26% -0.01%
==========================================
Files 133 133
Lines 14031 14061 +30
Branches 2957 2964 +7
==========================================
+ Hits 11825 11849 +24
- Misses 1466 1471 +5
- Partials 740 741 +1
|
BYK
commented
Oct 4, 2024
github-actions
bot
removed
the
Trigger: tests using secrets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brotli level 4 and 5 offer comparable or better compression to GZip
level 9 (which is our default) with better performance. This patch
adds opportunistic Brotli compression at level 4 (to be conservative)
when it detects the
brotlimodule is available. It also provides someescape hatches through
transport_compression_levelandtransport_compression_algoexperiment configs to fine tune the behavior.In the future, we may want to bump the default level from 4 to 5 for better
compression.