Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integrations): Do not use convenience decorator #3022

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Apr 25, 2024

Quick fix for #3021. Removing the decorator gets rid of the issue.

We should follow up and fix the decorator later, e.g. here: #2892

Closes #3021


General Notes

Thank you for contributing to sentry-python!

Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.

For maintainers

Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.

Before running sensitive test suites, please carefully check the PR. Then, apply the Trigger: tests using secrets label. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.

@sentrivana sentrivana marked this pull request as ready for review April 25, 2024 17:22
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add a test for whatever behavior the user observed in the issue. Can wait to be done in a separate PR

@sentrivana
Copy link
Contributor Author

Would be good to add a test for whatever behavior the user observed in the issue. Can wait to be done in a separate PR

This, or even better, figure out why our existing tests didn't discover this. As mentioned, the only thing it takes for it to error out is to have a super simple Starlette app and request any endpoint, which we already have tests for, but for some reason, they didn't fail.

@antonpirker antonpirker merged commit 162773c into master Apr 26, 2024
110 of 111 checks passed
@antonpirker antonpirker deleted the ivana/replace-ensure-integration-enabled-async branch April 26, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starlette fails with Uvicorn when instrumented with Sentry (2.0.0)
3 participants