Django caching instrumentation update #3009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def _patch_cache_method(cache, method_name): | ||
| # type: (CacheHandler, str) -> None | ||
| def _patch_cache_method(cache, method_name, address, port): | ||
| # type: (CacheHandler, str, Optional[str], Optional[str]) -> None | ||
| from sentry_sdk.integrations.django import DjangoIntegration | ||
|
|
||
| original_method = getattr(cache, method_name) | ||
|
|
||
| @ensure_integration_enabled(DjangoIntegration, original_method) |
There was a problem hiding this comment.
Suggested change
| @ensure_integration_enabled(DjangoIntegration, original_method) |
I think it makes more sense to place this on the sentry_method function. It is inaccurate to say that this method maps original_method because it has a different signature. Although, perhaps it would be more appropriate to make this change in a separate PR.
There was a problem hiding this comment.
Yes, probably better a new PR. Can you please create a ticket @szokeasaurusrex ?
| item_size = len(str(args[1])) | ||
|
|
||
| if item_size is not None: | ||
| span.set_data(SPANDATA.CACHE_ITEM_SIZE, item_size) | ||
|
|
||
| return value | ||
|
|
||
| @functools.wraps(original_method) |
There was a problem hiding this comment.
Suggested change
| @functools.wraps(original_method) | |
| @ensure_integration_enabled(DjangoIntegration, original_method) |
To be applied alongside my comment on (original version) line 41; also, likely makes sense to do in separate PR.
Co-authored-by: Daniel Szoke <[email protected]>
szokeasaurusrex
previously requested changes
May 10, 2024
Co-authored-by: Daniel Szoke <[email protected]>
…try/sentry-python into antonpirker/django-caching-module
antonpirker
dismissed
szokeasaurusrex’s stale review
All the changes where address from Daniels review, but he is out of office for some time, so I will dismiss this review so I can merge this.
sentrivana
approved these changes
May 22, 2024
arjennienhuis
pushed a commit
to arjennienhuis/sentry-python
that referenced
this pull request
Sep 30, 2024
This adds more data to the cache spans and makes adding the cache item size optional. This implements parts of following spec https://develop.sentry.dev/sdk/performance/modules/cache/ --------- Co-authored-by: Daniel Szoke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds more data to the cache spans and makes adding the cache item size optional.
This implements parts of following spec https://develop.sentry.dev/sdk/performance/modules/cache/
Documentation for manual instrumentation for the Cache module can be found here:
getsentry/sentry-docs#9926
Load testing of the feature was done here: #3058
Fixes #2964