ref(tornado): Use new scopes API #2907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sentrivana
force-pushed
the
ivana/2.0/tornado-new-scopes
branch
from
92e0dd9 to
7c89241
Compare
szokeasaurusrex
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to give the Tornado integration the new scopes treatment -- fixing that now.
This integration is a bit special because trying to update it to the new API leads to the tests failing with
when trying to restore the old isolation and current contexts at the end of
with isolation_scope(). Digging deeper, I came across a Tornado issue. There's a fix in Tornado 6 and also in our case, everything seems to work on 6.0 up, so I'm dropping support for older Tornado to make sure contextvars work correctly. 6.0 itself is already 5 years old so I think we can afford to drop support for older versions.