ref(starlite): Use new scopes API #2876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sentrivana
force-pushed
the
ivana/2.0/starlite-new-scopes
branch
from
74c31dc to
3333386
Compare
antonpirker
reviewed
Mar 22, 2024
|
|
||
| return await old_call(self, scope, new_receive, new_send) | ||
| else: | ||
| if sentry_sdk.get_client().get_integration(StarliteIntegration) is None: |
There was a problem hiding this comment.
We can use the @encure_... decorator here, no?
There was a problem hiding this comment.
I'd do this after we've fixed it and we're sure it works as intended, then we can go over the async integrations and add it.
Comment on lines
+179
to
183
| integration: StarliteIntegration = sentry_sdk.get_client().get_integration( | ||
| StarliteIntegration | ||
| ) | ||
| if integration is None: | ||
| return await old_handle(self, scope, receive, send) |
There was a problem hiding this comment.
We could also use the @ensure_... decorator here.
szokeasaurusrex
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Notes
Thank you for contributing to
sentry-python!Please add tests to validate your changes, and lint your code using
tox -e linters.Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.
For maintainers
Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.
Before running sensitive test suites, please carefully check the PR. Then, apply the
Trigger: tests using secretslabel. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.