ref: should_send_default_pii shortcut
#2844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 85c1a1f.
antonpirker
approved these changes
Mar 19, 2024
szokeasaurusrex
deleted the
szokeasaurusrex/should-send-default-pii-shortcut
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, with the new scope API, calls to
hub._should_send_default_piineed to be replaced with calls tosentry_sdk.get_client().should_send_default_pii.This PR introduces
scope.should_send_default_piias a drop-in replacement forhub._should_send_default_pii, so we don't need to type outsentry_sdk.get_client().should_send_default_piieverywhere we need to checkshould_send_default_pii.