Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(fastapi): Use new scopes API in FastAPI integration #2836

Merged
merged 23 commits into from
Mar 19, 2024
Merged

ref(fastapi): Use new scopes API in FastAPI integration #2836

merged 23 commits into from
Mar 19, 2024

Conversation

szokeasaurusrex
Copy link
Member

This PR updates the FastAPI integration to use the new Scopes API. The PR depends on #2454.

Fixes GH-2810

@szokeasaurusrex
Created async and sync decorators
190923c
@szokeasaurusrex
Added use of each sentry decorator
c8aeadb
@szokeasaurusrex
Fix circular import
c18a902
@szokeasaurusrex
Merge branch 'sentry-sdk-2.0' into szokeasaurusrex/sentry_patched_dec…
0fbea43 
…orator
@szokeasaurusrex
Revert changes to starlette.py
9f5c279
@szokeasaurusrex
Rename method
45b90ab
@szokeasaurusrex
Use actual generics, move async implementation to utils
69ebafb
@szokeasaurusrex
Refactor parameters
46cd0e2
@szokeasaurusrex
Undo changes to _types.py
7a8196a
@szokeasaurusrex
Use client instead of Hub
d9016db
@szokeasaurusrex
Add doc string
75934d1
@szokeasaurusrex
Move type comments
66726d0
@szokeasaurusrex
Merge branch 'sentry-sdk-2.0' into szokeasaurusrex/sentry_patched_dec…
4e48ce3 
…orator
@szokeasaurusrex
Fix _sentry_get_request_handler
8e5516d
@szokeasaurusrex
Fix mypy
e8c921c
@szokeasaurusrex
Fix circular import
20688fd
@szokeasaurusrex
Merge branch 'szokeasaurusrex/sentry_patched_decorator' into szokeasa…
3c38580 
…urusrex/fast-api-no-hub
@szokeasaurusrex
FastAPI without Hub usage
d017e09
@szokeasaurusrex szokeasaurusrex mentioned this pull request Mar 18, 2024
Merged
@szokeasaurusrex szokeasaurusrex linked an issue Mar 18, 2024 that may be closed by this pull request
[2.0] Update FastAPI integration to use new scopes #2810
Closed
Base automatically changed from szokeasaurusrex/sentry_patched_decorator to sentry-sdk-2.0 March 19, 2024 08:54
antonpirker
antonpirker approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
(Also checked test_fastapi.py and no hub in there)

@szokeasaurusrex szokeasaurusrex merged commit 553045b into sentry-sdk-2.0 Mar 19, 2024
111 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/fast-api-no-hub branch March 19, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonpirker antonpirker antonpirker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2.0] Update FastAPI integration to use new scopes
2 participants
@szokeasaurusrex @antonpirker