Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(uwsgi): Warn if uWSGI is set up without proper thread support #2738

Merged
merged 18 commits into from
Feb 15, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Feb 14, 2024

  • remove special treatment for uWSGI -- turn metrics on by default everywhere
  • remove the experimental force-enable-metrics flag
  • add a warning if uWSGI is not run with the necessary flags
  • move the existing uWSGI warning check from the worker to the client

TODO (separate docs PR): Call this out in the docs for wsgi framework integrations.

See #2699 (comment)

Closes #2699


General Notes

Thank you for contributing to sentry-python!

Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.

For maintainers

Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.

Before running sensitive test suites, please carefully check the PR. Then, apply the Trigger: tests using secrets label. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.

@sentrivana sentrivana marked this pull request as ready for review February 14, 2024 19:43
@sentrivana sentrivana changed the title ref(uwsgi): Warn if uWSGI is set up in an incompatible way ref(uwsgi): Warn if uWSGI is set up without proper thread support Feb 15, 2024
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@sentrivana sentrivana merged commit 4d1b814 into master Feb 15, 2024
123 checks passed
@sentrivana sentrivana deleted the ivana/detect-bad-forks branch February 15, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uWSGI workers dying in 1.40.0
2 participants