(5) Add reset() to thread local ContextVar and no-op copy_context()
#2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50-Course
reviewed
Dec 11, 2023
Comment on lines
1300
to
+1319
| try: | ||
| from aiocontextvars import ContextVar | ||
| from aiocontextvars import ContextVar, copy_context | ||
|
|
||
| return True, ContextVar | ||
| return True, ContextVar, copy_context | ||
| except ImportError: | ||
| pass | ||
| else: | ||
| # On Python 3.7 contextvars are functional. | ||
| try: | ||
| from contextvars import ContextVar | ||
| from contextvars import ContextVar, copy_context | ||
|
|
||
| return True, ContextVar | ||
| return True, ContextVar, copy_context | ||
| except ImportError: | ||
| pass | ||
|
|
||
| # Fall back to basic thread-local usage. | ||
|
|
||
| from threading import local | ||
|
|
||
| return False, _make_threadlocal_contextvars(local) | ||
| return False, _make_threadlocal_contextvars(local), _make_noop_copy_context() |
|
Following this MR 👍🏼 looking forward to the updates |
antonpirker
changed the base branch from
feat/new-scopes
to
antonpirker/refactor-hub-transaction-span-continue-trace
antonpirker
changed the title
reset() to thread local ContextVar and no-op copy_context()reset() to thread local ContextVar and no-op copy_context()
antonpirker
changed the base branch from
antonpirker/refactor-hub-transaction-span-continue-trace
to
feat/new-scopes
sl0thentr0py
approved these changes
Dec 18, 2023
sentry_sdk/utils.py
Outdated
| def reset(self, token): | ||
| # type: (Any) -> None | ||
| self._local.value = getattr(self._original_local, token) | ||
| setattr(self._original_local, token, None) |
There was a problem hiding this comment.
isn't it better to delete here so that it gets GCd?
There was a problem hiding this comment.
Hi @sl0thentr0py, please can you go into the detail about this tradeoff?
Thank you.
There was a problem hiding this comment.
@50-Course If it is not garbage collected it stays in memory. With a lot sets and resets the memory usage could grow without memory being freed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the capabilities of our threadlocal context variables, we use when no "real" context variables are available (for example in old Python versions)
This is preparation work for refactoring how we deal with Hubs and Scopes in the future.