Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring tests up to date #2512

Merged
merged 62 commits into from
Nov 24, 2023
Merged

Bring tests up to date #2512

merged 62 commits into from
Nov 24, 2023

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Nov 16, 2023

As part of our initiative to better keep up with new versions of libraries/frameworks we've integrated, we'll now also be testing against the latest version of libraries/frameworks.

While at it, I've also cleaned up our tox.ini to:

  • always test the lowest supported version of a framework
  • always test the latest version of a framework to catch incompatibilities earlier
  • if it makes sense for the integration, pinpoint a couple of versions in between to test against (especially if we do something differently in the integration based on the version)

The latest test suites run in their own jobs and are not required to pass in order to merge a PR. The idea is that if a latest test suite is failing, it's a signal for us to look into the integration and check what we need to fix, but it shouldn't prevent us from merging unrelated changes.

@sentrivana sentrivana marked this pull request as ready for review November 23, 2023 11:24
@sentrivana sentrivana enabled auto-merge (squash) November 23, 2023 11:41
auto-merge was automatically disabled November 23, 2023 16:07

Pull Request is not mergeable

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! 🥇

@@ -602,3 +602,21 @@ def create_mock_http_server():
mock_server_thread.start()

return mock_server_port


def unpack_werkzeug_response(response):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 !!!

@sentrivana sentrivana enabled auto-merge (squash) November 24, 2023 08:51
@sentrivana sentrivana merged commit a51132e into master Nov 24, 2023
468 checks passed
@sentrivana sentrivana deleted the ivana/clean-up-tox branch November 24, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants