Make sure get_dsn_parameters is an actual function
#2441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some non-standard DB backends have their own __getattr__, which renders our check for attributes useless.
sentrivana
changed the title
get_dsn_params is an actual functionget_dsn_parameters is an actual function
antonpirker
approved these changes
Oct 16, 2023
| and hasattr(cursor_or_db.connection, "get_dsn_parameters") | ||
| else db.get_connection_params() | ||
| ) | ||
| and inspect.isfunction(cursor_or_db.connection.get_dsn_parameters) |
There was a problem hiding this comment.
is there a world where this could be a coroutine?
There was a problem hiding this comment.
Shouldn't be, that's a psycopg2 sync function.
Btw, sidenote to this. Something I learned while looking at this is that newer Django uses psycopg (i.e., psycopg 3) instead of psycopg2. psycopg doesn't have this function. So this condition will always fall back to using get_connection_params instead. This is relevant because we added the get_dsn_parameters part to bypass calling get_connection_params for postgres.
There was a problem hiding this comment.
My hunch was correct 😞 Reopened the original issue: #2303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some non-standard Django DB connectors (djongo/pymongo) define their own
__getattr__, which renders our check for attributes trivially True, only to explode when actually trying to call the attribute as a function.Patch tested with
Closes #2438