Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics): Move minimetrics code to the SDK #2385

Merged
merged 36 commits into from
Sep 21, 2023
Merged

feat(metrics): Move minimetrics code to the SDK #2385

merged 36 commits into from
Sep 21, 2023

Conversation

mitsuhiko
Copy link
Member

@mitsuhiko mitsuhiko commented Sep 20, 2023 •
edited
Loading

This moves the minimetrics code from sentry to the SDK.

Todo:

  • move and adapt tests
  • support unicode values for tag values
  • implement gauges as gauges
  • add interface to emit internal metrics for deployment

Changes compared to original minimetrics:

  • client is gone
  • transport and encoder were replaced by a simple function
  • types were changed to better align with the sdk style
  • timing is implemented as a context manager, what was timing is now distribution
  • release, environment and transaction are attached

Fixes getsentry/sentry#55645

@mitsuhiko
fix: typing issues
c0de8c2
@mitsuhiko
fix: add missing metrics module
4a9c537
@mitsuhiko
feat: Reuse timestamp in timing
b0c410d
@mitsuhiko
test: Add tests
587cf9a
@mitsuhiko
feat: Enable gauges and add tests
70463ca
@mitsuhiko
test: Added multi-metric test
8b494b1
@mitsuhiko
fix: lint
22705c2
@mitsuhiko
feat: add transaction name to metrics
feb8c9b
@mitsuhiko
fix: duplicate test name
cafc747
@mitsuhiko
fix: typing
48abc5d
@mitsuhiko
Add missing space
cd2597a
@mitsuhiko
feat: return envelope to allow capturing of metrics
c67ddf0
@mitsuhiko
feat: Unicode support for tag values
daf0ee1
@mitsuhiko
Add newline
7bd88b0
@mitsuhiko
feat: Added before_emit_metric
a21e683
@mitsuhiko
feat: Add timed decorator
b1ba79e
@mitsuhiko
ref: Unify timed and timing
80cef70
@mitsuhiko
fix: Remove unused ts
54a49ff
@mitsuhiko
Fix lints
799a436
@mitsuhiko
Fix typing error
0417e7b
@mitsuhiko
Make 2.7 happy
e9d2eee
@mitsuhiko
fix: newstyle type syntax
ed866fc
@mitsuhiko
Fix unicode literal
2273176
@mitsuhiko
Reformat
de9049a
@mitsuhiko
Mark string as unicode
c37ed6f
@mitsuhiko
Make black not strip u prefixes on some tests
b16bee4
@mitsuhiko
Add back removed utf-8 coding marker
be7756b
@mitsuhiko
feat: Allow non integer tag values
1f18562
This was referenced Sep 21, 2023
Merged
Closed
Closed
jan-auer
jan-auer reviewed Sep 21, 2023
View reviewed changes
sentry_sdk/_types.py Show resolved Hide resolved
sentry_sdk/metrics.py Show resolved Hide resolved
sentry_sdk/metrics.py Show resolved Hide resolved
sentry_sdk/metrics.py Outdated Show resolved Hide resolved
antonpirker
antonpirker approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because Jan said lgtm

@mitsuhiko mitsuhiko merged commit 0dd7d5f into master Sep 21, 2023
257 checks passed
@mitsuhiko mitsuhiko deleted the feature/minimetrics branch September 21, 2023 12:40
This was referenced Oct 16, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-auer jan-auer jan-auer left review comments

@antonpirker antonpirker antonpirker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send release and environment alongside custom metrics
3 participants
@mitsuhiko @antonpirker @jan-auer