Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Falcon integration from breaking ASGI apps #2359

Merged
merged 7 commits into from
Sep 12, 2023

Conversation

szokeasaurusrex
Copy link
Member

Fixes #1946 and supersedes #2346

@szokeasaurusrex szokeasaurusrex enabled auto-merge (squash) September 8, 2023 12:37
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@szokeasaurusrex szokeasaurusrex merged commit 90c64ca into master Sep 12, 2023
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/falcon-fix-second-attempt branch September 12, 2023 09:14
sentrivana pushed a commit that referenced this pull request Sep 18, 2023
* Prevent Falcon integration from breaking ASGI apps

* Remove trailing comma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sentry-sdk stopped working with falcon 3+ asgi app
2 participants