Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiler): Do not call getcwd from module root #2329

Merged
merged 4 commits into from
Aug 30, 2023

Conversation

Zylphrex
Copy link
Member

When calling sentry from a cleaned up path, it should not cause an error. So defer the os.getcwd() call until later.

Fixes #2324.

When calling sentry from a cleaned up path, it should not cause an error. So
defer the `os.getcwd()` call until later.

Fixes #2324.
@Zylphrex Zylphrex requested a review from sentrivana August 29, 2023 15:10
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sentrivana sentrivana enabled auto-merge (squash) August 30, 2023 07:25
@sentrivana sentrivana merged commit 7a7867b into master Aug 30, 2023
@sentrivana sentrivana deleted the txiao/fix/do-not-call-getcwd-from-module-root branch August 30, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invoking sentry when in a path that does not exist causes a FileNotFoundError
2 participants