-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/add .vscode to .gitignore #2317
Enhancement/add .vscode to .gitignore #2317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
It looks like your PR includes several changes unrelated to adding .vscode to .gitignore. Please remove these changes from your PR so we can merge it.
6117f34
to
95b0020
Compare
Hello szokeasaurusrex |
Thank you for attempting to remove the unwanted changes; it looks like you were able to undo some of the changes, but some files were still being changed by the pre-commit hooks. I looked into this issue and was able to fix your PR by undoing the unwanted changes and then committing with the |
* + Add .vscode to .gitignore #2291 * + Add .vscode to .gitignore #2291 * + delete .vscode #2291 * Update .flake8 * Update .flake8 * Update config.yml * Update test-requirements.txt * Update init_serverless_sdk.py * Update build_aws_lambda_layer.py * Update LICENSE * Update LICENSE * Update dependabot.yml * Update LICENSE * Update .flake8 * Revert unwanted changes --------- Co-authored-by: Anton Pirker <[email protected]> Co-authored-by: Daniel Szoke <[email protected]>
Add .vscode to .gitignore #2291
As szokeasaurusrex Said in the problem statement mentioned below
Problem Statement
The .vscode directory, which is used to store local VSCode configuration options, is being tracked by Git. Since my local settings differ from what is stored in the repo, I always need to make sure not to stage my .vscode directory when commuting changes in Git. Since different developers may have different VSCode configurations, I don’t see any reason why we should be tracking this directory in our repo.
Solution Brainstorm
Add the .vscode directory to .gitignore. If we implement this change, we should probably also delete the .vscode directory from the GitHub repo.
I have successfully deleted the .vscode directory from the project and also added .vscode directory in .gitignore file.