-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the url as a transaction name ... #2264
Closed
antonpirker
wants to merge
17
commits into
master
from
antonpirker/2262-traces-sampler-url-instead-of-generic-asgi-request
Closed
Set the url as a transaction name ... #2264
antonpirker
wants to merge
17
commits into
master
from
antonpirker/2262-traces-sampler-url-instead-of-generic-asgi-request
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the beginning, so has something to work with
…e to discuss how to move forward
…d-of-generic-asgi-request
…d-of-generic-asgi-request
…d-of-generic-asgi-request
Closing in favor of #2341 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... instead of 'generic ASGI request' in the beginning, so
traces_sampler
has something to work with that is more meaningful than 'generic ASGI request'.Closes #2262