This disables Django Cache spans by default. #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonpirker
changed the title
antonpirker
commented
May 17, 2023
| @@ -1029,6 +1027,8 @@ def test_cache_spans_middleware( | |||
| ], | |||
| traces_sample_rate=1.0, | |||
| ) | |||
|
|
|||
| client.application.load_middleware() | |||
There was a problem hiding this comment.
By changing the default it was uncovered, that this test only worked by coincidence. Had to load the middleware after sdk init, to have the options set in DjangoIntegration.
sl0thentr0py
approved these changes
May 17, 2023
sentrivana
pushed a commit
that referenced
this pull request
May 19, 2023
* Made Django Cache spans disabled by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users were telling us that the cache spans are adding to much overhead onto their servers, so we are disabling cache spans by default and make them opt-in.