-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align HTTP status code as span data field http.response.status_code
#2113
Conversation
http.status_code
everywhere in same format.http.status_code
…try/sentry-python into antonpirker/2099-http-status-code
http.status_code
http.response.status_code
…try/sentry-python into antonpirker/2099-http-status-code
A note: The OTel docs for their semantic conventions [1] say that it is called But the OTel Python SDK still uses Anyhow, the Sentry Otel integrations uses the variables from the OTel Python SDK, so if an OTel span has 1: https://opentelemetry.io/docs/specs/otel/metrics/semantic_conventions/http-metrics/#http-server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo, otherwise LGTM
Co-authored-by: Ivana Kellyerova <[email protected]>
Send HTTP status codes as an
integer
in a Span data field calledhttp.response.status_code
.This will align us with OTel. Also see:
Fixes #2099