-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove relay extension from AWS layer #2068
Conversation
daa3804
to
47ab86d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments in "Conversation" tab.
2f4e16b
to
13853af
Compare
13853af
to
2bb95b3
Compare
* Add `loguru` integration Actually, this is the solution in comments under #653 adapted to codebase and tested as well. #653 (comment) I also changed `logging` integration to use methods instead of functions in handlers, as in that way we can easily overwrite parts that are different in `loguru` integration. It shouldn't be a problem, as those methods are private and used only in that file. --------- Co-authored-by: Anton Pirker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good and the resulting layer zip looks similar enought to the old one. So LGTM.
we're reverting back to the older setup since the whole 'relay as AWS extension' experiment didn't really work out. * revert port override in DSN * remove gh action that bundles relay * zip in place as part of `make build_aws_lambda_layer` part of getsentry/team-webplatform-meta#58
I came across this issue while investigating how to setup the aws lambda extension for some python lambdas I have integrated with sentry. My original goal was to improve lambda performance when events are delivered to sentry.io. I found docs on how to setup a more point and click integration with lambda here: https://docs.sentry.io/product/integrations/cloud-monitoring/aws-lambda/#configure but these don't seem to have limited configuration support through a few environment variables, where I have specific config for the sentry python sdk and a few integrations that don't appear to be supported. Is the lambda extension running relay no longer supported? |
we're reverting back to the older setup since the whole 'relay as AWS extension' experiment didn't really work out.
make build_aws_lambda_layer
part of getsentry/team-webplatform-meta#58