Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Django signals tracing optional #1929

Merged
merged 5 commits into from
Mar 1, 2023
Merged

Make Django signals tracing optional #1929

merged 5 commits into from
Mar 1, 2023

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Mar 1, 2023 •
edited
Loading

Adds an option signals_spans to the DjangoIntegrations that works the same as middleware_spans so the tracing of Django signals can be turned of.

Also I cleaned up the tests a bit.

Fixes #1893

@antonpirker antonpirker marked this pull request as ready for review March 1, 2023 12:09
@antonpirker antonpirker requested a review from sl0thentr0py March 1, 2023 12:53
@antonpirker antonpirker merged commit ad3724c into master Mar 1, 2023
@antonpirker antonpirker deleted the antonpirker/make-django-signals-tracing-optional branch March 1, 2023 13:06
@ron8mcr ron8mcr mentioned this pull request Mar 23, 2023
Closed
@mlazowik mlazowik mentioned this pull request Dec 7, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slow performance when Sentry integration is enabled
2 participants
@antonpirker @sl0thentr0py