ref(profiling): Use the transaction timestamps to anchor the profile #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want the profile to be as closely aligned with the transaction's timestamps as possible to make aligning the two visualizations as accurate as possible. Here we change the transaction's internal `_start_timestamp_monotonic` to contain an unit for each of the possible clocks we use in the various python versions. This allows us to use the `start_timestamp` of the transaction as the timestamp of the profile, and we can use the `_start_timestamp_monontonic` as the anchor for all the relative timestamps in the profile.
phacops
reviewed
Feb 14, 2023
phacops
approved these changes
Feb 14, 2023
…o-anchor-the-profile
…o-anchor-the-profile
…o-anchor-the-profile
sl0thentr0py
approved these changes
Feb 15, 2023
…profile' of github.com:getsentry/sentry-python into txiao/ref/use-the-transaction-timestamps-to-anchor-the-profile
Zylphrex
deleted the
txiao/ref/use-the-transaction-timestamps-to-anchor-the-profile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the profile to be as closely aligned with the transaction's timestamps as possible to make aligning the two visualizations as accurate as possible. Here we change the transaction's internal
_start_timestamp_monotonicto be in nanoseconds derived from each of the possible clocks we use in the various python versions. This allows us to use thestart_timestampof the transaction as the timestamp of the profile, and we can use the_start_timestamp_monontonicas the anchor for all the relative timestamps in the profile.