Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic OTel support #1772

Merged
merged 19 commits into from
Dec 14, 2022
Merged

Basic OTel support #1772

merged 19 commits into from
Dec 14, 2022

Conversation

antonpirker
Copy link
Member

Adding basic OpenTelementry (OTel) support to the Sentry SDK:

  • Adding a OTel SpanProcessor that can receive spans form OTel and then convert them into Sentry Spans and send them to Sentry.
  • Adding a OTel Propagator that can receive and propagate trace headers (Baggage) to keep distributed tracing intact.

@antonpirker antonpirker mentioned this pull request Dec 1, 2022
Closed
@antonpirker antonpirker added this to the Basic OTel support milestone Dec 1, 2022
@antonpirker antonpirker changed the title OTel support (added SpanProcessor and Propagator) Baseic OTel support Dec 1, 2022
@antonpirker antonpirker changed the title Baseic OTel support Basic OTel support Dec 1, 2022
@sl0thentr0py sl0thentr0py self-requested a review December 5, 2022 13:08
@sl0thentr0py
Copy link
Member

we need a line in setup.py in extras_require

sl0thentr0py
sl0thentr0py reviewed Dec 5, 2022
View reviewed changes
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed SpanProcessor

sentry_sdk/tracing.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/opentelemetry/span_processor.py Show resolved Hide resolved
sentry_sdk/integrations/opentelemetry/span_processor.py Show resolved Hide resolved
sentry_sdk/integrations/opentelemetry/span_processor.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/opentelemetry/span_processor.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/opentelemetry/span_processor.py Show resolved Hide resolved
sl0thentr0py
sl0thentr0py previously requested changes Dec 5, 2022
View reviewed changes
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright did propagator too, will do another round once all this is changed

sentry_sdk/integrations/opentelemetry/propagator.py Show resolved Hide resolved
sentry_sdk/integrations/opentelemetry/propagator.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/opentelemetry/span_processor.py Show resolved Hide resolved
sentry_sdk/integrations/opentelemetry/span_processor.py Show resolved Hide resolved
sentry_sdk/integrations/opentelemetry/propagator.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/opentelemetry/propagator.py Show resolved Hide resolved
sentry_sdk/integrations/opentelemetry/propagator.py Outdated Show resolved Hide resolved
@smeubank smeubank linked an issue Dec 7, 2022 that may be closed by this pull request
Basic OpenTelemetry (OTEL) Support #1687
Closed
@antonpirker antonpirker force-pushed the antonpirker/1687-basic-otel branch from bf57f69 to 031e79a Compare December 13, 2022 10:37
@antonpirker antonpirker merged commit d0eed0e into master Dec 14, 2022
@antonpirker antonpirker deleted the antonpirker/1687-basic-otel branch December 14, 2022 15:12
@tonyo tonyo restored the antonpirker/1687-basic-otel branch December 16, 2022 16:05
@tonyo tonyo deleted the antonpirker/1687-basic-otel branch December 20, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladanpaunovic vladanpaunovic vladanpaunovic approved these changes

@sl0thentr0py sl0thentr0py Awaiting requested review from sl0thentr0py

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Basic OTel support
Development

Successfully merging this pull request may close these issues.

Basic OpenTelemetry (OTEL) Support
3 participants
@antonpirker @sl0thentr0py @vladanpaunovic