-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instrumenter config to switch between Otel and Sentry instrumentation. #1766
Merged
antonpirker
merged 13 commits into
master
from
antonpirker/1687-basic-otel-support-2-instrumenter
Dec 1, 2022
Merged
Add instrumenter config to switch between Otel and Sentry instrumentation. #1766
antonpirker
merged 13 commits into
master
from
antonpirker/1687-basic-otel-support-2-instrumenter
Dec 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl0thentr0py
requested changes
Nov 30, 2022
sl0thentr0py
changed the base branch from
master
to
antonpirker/1687-basic-otel-support-1-preparations
November 30, 2022 13:46
Base automatically changed from
antonpirker/1687-basic-otel-support-1-preparations
to
master
November 30, 2022 15:22
* Api for setting arbitrary contexts in transactions.
* Add parameter to set `start_timestamp` and `end_timestamp` on Span creation or finishing
…github.com:getsentry/sentry-python into antonpirker/1687-basic-otel-support-2-instrumenter
sl0thentr0py
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if tests are in another PR, it's fine, otherwise please add some tests for checking that the no-ops work correctly
antonpirker
deleted the
antonpirker/1687-basic-otel-support-2-instrumenter
branch
December 1, 2022 11:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.