-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have instrumentation for ASGI middleware receive/send callbacks. #1673
Have instrumentation for ASGI middleware receive/send callbacks. #1673
Conversation
… of github.com:getsentry/sentry-python into antonpirker/1664-fix-parent-span-in-fastapi-middleware
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one question, and
in cases like these where we add some feature, can you attach a testing screenshot so that somebody who looks at the PR from the changelog can see clearly what changed?
Good idea! |
To better visualize what is going on when ASGI middlewares are executed we added instrumentation for the
receive
andsend
callbacks.FIxes #1664
Before it seemed that the
db.redis
span originated in theAsyncExitStackMiddleware
:Now you see that the
db.redis
span actually originates in asend
callback that is defined inMyCustomCounterMiddleware.__call__.<locals>.count_hits_to_url
: