Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1386 - is_valid_sample_rate-toostrict #1672

Merged
merged 2 commits into from
Oct 11, 2022
Merged

Fixes #1386 - is_valid_sample_rate-toostrict #1672

merged 2 commits into from
Oct 11, 2022

Conversation

Arvind2222
Copy link
Contributor

  • Fix is_valid_sample_rate to allow check on Decimal

@Arvind2222
Fixes getsentry#1386
8b6e3a3 
* Fix is_valid_sample_rate to allow check on `Decimal`
@Arvind2222 Arvind2222 mentioned this pull request Oct 11, 2022
Closed
@Arvind2222
Copy link
Contributor Author

@antonpirker @mitsuhiko Can you please review

sl0thentr0py
sl0thentr0py approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @Arvind2222

@sl0thentr0py sl0thentr0py enabled auto-merge (squash) October 11, 2022 09:34
@sl0thentr0py sl0thentr0py merged commit 6e0b02b into getsentry:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arvind2222 @sl0thentr0py