Fix for partial signals in old Django and old Python versions. #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,9 +21,14 @@ def patch_signals(): | |||
|
|
|||
| def _get_receiver_name(receiver): | |||
| # type: (Callable[..., Any]) -> str | |||
| name = receiver.__module__ + "." | |||
| if hasattr(receiver, "__module__"): | |||
There was a problem hiding this comment.
can't we just use __qualname__ here?
There was a problem hiding this comment.
Good idea.
But I checked, the partials also do not have a __qualname__, so: no.
There was a problem hiding this comment.
oh, but we can use __qualname__ if there is one, and if not we use __name__
sl0thentr0py
requested changes
Sep 27, 2022
sl0thentr0py
approved these changes
Sep 28, 2022
This was referenced Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making sure signal name can also be set when partials are used as signal in old Django versions in old Python versions.
Fixes #1640