fix(profiling): Dynamically adjust profiler sleep time #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because more time may have elapsed between 2 samples due to us calling the sampling function and other threads executing, we need to account for it in the sleep or the time between samples will often be greater than the expected interval. This change ensures we account for this time elapsed and dynamically adjust the amount of time we sleep for between samples.
phacops
reviewed
Sep 21, 2022
| now = time.perf_counter() | ||
| elapsed = max(now - last, 0) | ||
|
|
||
| if elapsed < self._interval: |
There was a problem hiding this comment.
I'm not sure why you test this before you sleep. Shouldn't we sleep all the time at least a little bit, just the remaining amount of time until self._interval passed?
There was a problem hiding this comment.
If the elapsed time is greater than self._interval, then we'd want to sample as soon as possible otherwise the time between the 2 samples will be much larger than expected. This is because other threads could be running without giving this thread a chance to execute.
sl0thentr0py
approved these changes
Sep 26, 2022
Zylphrex
deleted the
txiao/fix/dynamically-adjust-profiler-sleep-time
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because more time may have elapsed between 2 samples due to us calling the sampling function and other threads executing, we need to account for it in the sleep or the time between samples will often be greater than the expected interval. This change ensures we account for this time elapsed and dynamically adjust the amount of time we sleep for between samples.