feat(profiling): Convert profile output to the sample format #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zylphrex
reviewed
Sep 13, 2022
sentry_sdk/profiler.py
Outdated
| current_stack.append(frames[frame]) | ||
|
|
||
| try: | ||
| stack_idx = stacks.index(current_stack) |
There was a problem hiding this comment.
I have no clue what the sizes of these are, but why not do the same optimization as with frames and frames_list, so have a dict stacks_dict and a list stacks_list instead of walking the current stacks list with index?
There was a problem hiding this comment.
oh ok @Zylphrex said the same, did not refresh
sl0thentr0py
approved these changes
Sep 13, 2022
Zylphrex
reviewed
Sep 13, 2022
Zylphrex
reviewed
Sep 15, 2022
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Zylphrex
requested changes
Sep 26, 2022
…more in profiler.py
Zylphrex
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're looking to introduce a new profile format referred to as the Sample format (getsentry/relay#1462). This PR implements this format.